Align data versions: DataVersionSupplier ↔ NBT-API-DataFixerUtil#631
Draft
CatTeaA wants to merge 1 commit intoWiIIiam278:masterfrom
Draft
Align data versions: DataVersionSupplier ↔ NBT-API-DataFixerUtil#631CatTeaA wants to merge 1 commit intoWiIIiam278:masterfrom
CatTeaA wants to merge 1 commit intoWiIIiam278:masterfrom
Conversation
Owner
|
I'd like to understand and test this a bit deeper what this change means as these version IDs govern how HuskSync calls the DFU to update item stack data versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HuskSync/bukkit/src/main/java/net/william278/husksync/data/BukkitSerializer.java
Lines 156 to 160 in ac163d5
The data version in HuskSync-DataVersionSupplier may be higher than that in NBTAPI-DataFixerUtil. For example, in version 1.21.8, the data version of HuskSync is 4438, while that of NBTAPI is 4435.
There may be a check in subsequent conversions that directly returns the original data when fromVersion >= toVersion, but I'm not certain.