Skip to content

Align data versions: DataVersionSupplier ↔ NBT-API-DataFixerUtil#631

Draft
CatTeaA wants to merge 1 commit intoWiIIiam278:masterfrom
CatTeaA:A1
Draft

Align data versions: DataVersionSupplier ↔ NBT-API-DataFixerUtil#631
CatTeaA wants to merge 1 commit intoWiIIiam278:masterfrom
CatTeaA:A1

Conversation

@CatTeaA
Copy link
Copy Markdown
Contributor

@CatTeaA CatTeaA commented Dec 11, 2025

return DataFixerUtil.fixUpItemData(
tag,
getPlugin().getDataVersion(mcVersion),
DataFixerUtil.getCurrentVersion()
);

The data version in HuskSync-DataVersionSupplier may be higher than that in NBTAPI-DataFixerUtil. For example, in version 1.21.8, the data version of HuskSync is 4438, while that of NBTAPI is 4435.

There may be a check in subsequent conversions that directly returns the original data when fromVersion >= toVersion, but I'm not certain.

@CatTeaA CatTeaA marked this pull request as draft December 11, 2025 09:40
@WiIIiam278
Copy link
Copy Markdown
Owner

I'd like to understand and test this a bit deeper what this change means as these version IDs govern how HuskSync calls the DFU to update item stack data versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants