Skip to content

Merge other PR and fix out of range XP #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Emibergo02 merged 3 commits into from
Feb 10, 2026
Merged

Merge other PR and fix out of range XP #645

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb7e79f
fix: prevent double version upgrade when processing item data
tangjin0418 Jan 29, 2026
f89420c
Handles #644
Emibergo02 Feb 6, 2026
56034fa
Revert "fix: prevent double version upgrade when processing item data"
Emibergo02 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion bukkit/src/main/java/net/william278/husksync/data/BukkitData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,10 @@ private static AttributeModifier adapt(@NotNull Modifier modifier) {
public void apply(@NotNull BukkitUser user, @NotNull BukkitHuskSync plugin) throws IllegalStateException {
if (!Bukkit.isPrimaryThread()) {
try {
Bukkit.getScheduler().callSyncMethod(plugin, () -> { this.apply(user, plugin); return null; }).get();
Bukkit.getScheduler().callSyncMethod(plugin, () -> {
this.apply(user, plugin);
return null;
}).get();
return;
} catch (Exception e) {
throw new IllegalStateException("Failed to apply attributes on main thread", e);
Expand Down Expand Up @@ -809,6 +812,10 @@ public void apply(@NotNull BukkitUser user, @NotNull BukkitHuskSync plugin) thro
final Player player = user.getPlayer();
player.setTotalExperience(totalExperience);
player.setLevel(expLevel);
if (expProgress < 0f || expProgress > 1f) {
plugin.log(Level.WARNING, "Invalid experience progress value: " + expProgress + ". Must be between 0 and 1.");
return;
}
player.setExp(expProgress);
}

Expand Down