Conversation
- Added case insensitivity and input normalization/sanitation for student names, grades, and time. - Added error handling for missing sheets, failed sheet operations. - Greyed out Grade radio button selection. Added help tooltip with instructions for correcting student grade, if incorrect. - Converted all web push notifications to popups within the webpage itself. - Made many CSS styling improvements. - Improved code comments and formatting.
… popup Also revised CSS class names in `Stylesheet` to ensure inclusivity.
Previously, if the user attempted to submit the form with an amended, non-current time, the current time would still go to the Logs.
Previously, any returning student would face an "Invalid Grade" error message upon attempting to submit the form.
tomgagnier
reviewed
Mar 25, 2026
| if (data.length > 0) data.shift(); | ||
| // Sanitize and normalize input | ||
| let name = String(formObject.studentName || "").trim(); | ||
| let normName = name.toLowerCase(); |
There was a problem hiding this comment.
consider creating a function safeTrim(..) to avoid repetition
tomgagnier
reviewed
Mar 25, 2026
| } | ||
| // Validate Time format (HH:mm) | ||
| if (!/^\d{2}:\d{2}$/.test(timeString)) { | ||
| return { status: "ERROR", message: "Invalid time format." }; |
There was a problem hiding this comment.
Improve message to indicate expected format
"Invalid time format, expected HH:MM"
tomgagnier
reviewed
Mar 25, 2026
| const statusCell = sheet.getRange(rowIndex, COL_STATUS); | ||
|
|
||
| if (type === "Check In") { | ||
| // Set Status text and color |
There was a problem hiding this comment.
Comment is good, a constant is better -- LIGHT_GREEN.
tomgagnier
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JavaScript.htmlfile is used instead of a.gsfile because Google Apps Script executes.gscode on the server side, whereas this project requires client-side logic to interact with the browser's Document Object Model (DOM). Since the Google Apps Script editor does not support native.jsfiles, frontend logic must be wrapped in<script>tags within an.htmlfile and injected into the main page using theinclude()helper function.Furthermore,
JavaScript.html,Index.html, andStylesheet.htmlare kept as distinct files to ensure a strict separation of concerns, improving the overall maintainability and readability of the codebase.