Fix macOS .app bundle support for game launch#259
Open
cantunborn wants to merge 1 commit into
Open
Conversation
.app bundles are directories on macOS and could not be selected in the file picker or validated/launched as executables. Treat .app dirs as files in the picker, accept them in validate_executables(), and launch them via the macOS `open` command in _launch_exe(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
Problem
On macOS, game applications are distributed as
.appbundles which aredirectories on the filesystem, not files. This caused three failures:
.appdirs appeared as folders; double-clickingnavigated into them instead of selecting them as an executable
validate_executables()usesis_file(), whichalways returns
Falsefor.appbundles, so games were never markedas installed
_launch_exe()raisedFileNotFoundErrorbecause ofthe same
is_file()checkFix
external/filepicker.py—.appdirs display with a file icon onmacOS, making them selectable
modules/callbacks.py—_launch_exe()launches.appdirs via theopencommand on macOScommon/structs.py—validate_executables()accepts.appdirs asvalid in all three code paths
No changes to Linux or Windows behavior.