Skip to content

Sticky highlight the game showing in the More Info popup#260

Open
FaceCrap wants to merge 2 commits into
WillyJL:mainfrom
FaceCrap:sticky_highlight
Open

Sticky highlight the game showing in the More Info popup#260
FaceCrap wants to merge 2 commits into
WillyJL:mainfrom
FaceCrap:sticky_highlight

Conversation

@FaceCrap
Copy link
Copy Markdown
Contributor

When using the More Info popup's Left/Right buttons, the game currently showing in the popup, will have the 'CTRL-Click' highlight applied. Since it uses the Ctrl-Click select highlight, it will remain 'selected' when the popup is closed. This makes it easier to localize the last-viewed game when the list or view contains many games even when the game is off-screen when the popup is closed.

In Kanban view, this may act a little differently than expected, since the popup will follow the list order, and the last viewed game may be in a totally different Kanban column than where you started viewing.

I've included a small screen recording to show this in action

sticky800.webm

FaceCrap and others added 2 commits March 18, 2026 22:00
When using the More Info popup's Left/Right buttons, the game currently showing in the popup, will have the 'CTRL-Click' highlight applied.
Since it uses the Ctrl-Click select highlight, it will remain 'selected' when the popup is closed. This makes it easier to localize the last-viewed game when the list or view contains many games even when  the game is off-screen when the popup is closed.

In Kanban view, this may act a little differently than expected, since the popup will follow the list order, and the last viewed game may be in a totally different Kanban column than where you started viewing.
@FaceCrap
Copy link
Copy Markdown
Contributor Author

FaceCrap commented Mar 22, 2026

Changed it so that when you close the More Info popup, you can immediately click either the last selected game or another game to re-open the More Info popup instead of first having to click-deselect the game marked as selected.
This is done with if self.last_selected_game != None:, if it isn't, we first deselect that game before marking the next clicked game as selected, then update it with the clicked game so we can deselect it right before re-opening the More Info popup with another game.
Also changed the if any(game.selected for game in globals.games.values()): statement to reuse the already present self.selected_games_count so we don't need to first loop through games to check if any are selected before looping again to deselect them.

This does require either a CTRL-Click on the last selected game or a tab switch to remove the select highlight if you don't plan on opening another More Info popup.
But then again, that's inherent if you want the last viewed game to remain highlighted after closing the popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant