-
Notifications
You must be signed in to change notification settings - Fork 445
Create a log file for debugging pointwatch message ids #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Slips lib Update
Linkshell name and color fixes
See discord message
Check for Nomad/Pilgrim Moogles at the start of the command. Added appropriate debug notices.
Initiate menu interaction with Moogles before using Mog House bags.
Further improved Nomad/Pilgrim Moogle check
Update roe.lua
Dev > Live Merge
Typo fix `clear_moogle` to `clear_moogles`
Added a comment instructing users not to add Pilgrim Moogles manually, as it won't work.
Version bump and Pilgrim Moogle removal.
Dev > Live
[Battlemod] Several updates and fixes.
Dev > Live
Update for incoming packet 0x075
[pointwatch] support Master Levels (specifically)
…bbrs [pointwatch] support job names and abbreviations
add yell and linkshell2 support
Fix weird interaction with Gearswap
Update digger messages for 2022-04 version
…2204 Update boxdestroyer for the 2022-04 version
Adding the items from the April 2022 FFXI Update.
[Slips lib] April 2022 Update
Occasionally addon will try to resume crafting too quickly after interacting with support npc causing entire queue to be dumped with "you cannot craft at this time" errors. Added a short delay in the check_queue function after poke_npc() call.
Support bug fix
Update to properly handle more valid commands
FindAll -- Allow for start/end pattern matching
This would create a small file in the data folder after reading from a dialog dat. If someone noticed buggy behavior with the offsets, they could verify that the number in the log file matches the number they get from following the steps in the fixing pointwatch file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not sure what this does, but if I also don't know much about PW or how it handles DAT files. Is this done automatically, always? Or only with some debug flag? Because I would very much prefer the latter. If someone has an issue they could still be told to enable the flag and reproduce it, right? This is otherwise just a lot of extra work that seems needless for regular operations.
| f:write(os.date() .. '\n' .. table.concat(s, '\n')) | ||
| f:close() | ||
| end | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this end not one too many? Or what is it meant to close?
| m.offset = res[1] | ||
| m.name = nil | ||
| m.update = nil | ||
| local s = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer some better variable names. I realize that m and f also weren't perfect before, but no need to repeat those mistakes :) In fact, can adjust them while you're in there.
| s[n] = t.name .. '\t' .. tostring(t.offset) | ||
| end | ||
| end | ||
| if n > 0 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't n always be > 0? At least 1, because you set m.update to nil above, so if you iterate the messages after that, at least the current message (m) would result in not t.update being true?
This would create a small file in the data folder after reading from a dialog dat. If someone noticed buggy behavior with the offsets, they could verify that the number in the log file matches the number they get from following the steps in the fixing pointwatch file.