Skip to content

Conversation

@trv6
Copy link
Contributor

@trv6 trv6 commented Apr 26, 2022

This would create a small file in the data folder after reading from a dialog dat. If someone noticed buggy behavior with the offsets, they could verify that the number in the log file matches the number they get from following the steps in the fixing pointwatch file.

z16 and others added 30 commits July 13, 2021 15:05
See discord message
Check for Nomad/Pilgrim Moogles at the start of the command.
Added appropriate debug notices.
Initiate menu interaction with Moogles before using Mog House bags.
Further improved Nomad/Pilgrim Moogle check
Typo fix `clear_moogle` to `clear_moogles`
Added a comment instructing users not to add Pilgrim Moogles manually, as it won't work.
Version bump and Pilgrim Moogle removal.
[Battlemod] Several updates and fixes.
Update for incoming packet 0x075
posimagi and others added 28 commits March 12, 2022 18:45
[pointwatch] support Master Levels (specifically)
…bbrs

[pointwatch] support job names and abbreviations
Fix weird interaction with Gearswap
Update digger messages for 2022-04 version
…2204

Update boxdestroyer for the 2022-04 version
Adding the items from the April 2022 FFXI Update.
Occasionally addon will try to resume crafting too quickly after interacting with support npc causing entire queue to be dumped with "you cannot craft at this time" errors.  Added a short delay in the check_queue function after poke_npc() call.
Update to properly handle more valid commands
FindAll -- Allow for start/end pattern matching
This would create a small file in the data folder after reading from a dialog dat. If someone noticed buggy behavior with the offsets, they could verify that the number in the log file matches the number they get from following the steps in the fixing pointwatch file.
Copy link
Member

@z16 z16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not sure what this does, but if I also don't know much about PW or how it handles DAT files. Is this done automatically, always? Or only with some debug flag? Because I would very much prefer the latter. If someone has an issue they could still be told to enable the flag and reproduce it, right? This is otherwise just a lot of extra work that seems needless for regular operations.

f:write(os.date() .. '\n' .. table.concat(s, '\n'))
f:close()
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this end not one too many? Or what is it meant to close?

m.offset = res[1]
m.name = nil
m.update = nil
local s = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer some better variable names. I realize that m and f also weren't perfect before, but no need to repeat those mistakes :) In fact, can adjust them while you're in there.

s[n] = t.name .. '\t' .. tostring(t.offset)
end
end
if n > 0 then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't n always be > 0? At least 1, because you set m.update to nil above, so if you iterate the messages after that, at least the current message (m) would result in not t.update being true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.