-
Notifications
You must be signed in to change notification settings - Fork 445
Yush: Fix for wrong action being activated with overlapping key config. (1 and ctrl+1 f.e.) #2198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vessellaj
wants to merge
1,328
commits into
Windower:dev
Choose a base branch
from
vessellaj:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Slips libs for September FFXI update
Update slips.lua
Two new songs added in the September 2021 update. Names are not known yet.
Update setbgm.lua
…strosity-fix Gearswap shortcuts monstrosity fix
Locals, spacing dev table, format arg, no more length the rest of the owl
Dev -> Live
A few functions for decoding dialog entries
change based on CHA CHA CHA's info
fixed comment numbering for 0x01C
Dev -> Live
Add blacklist function.
Master Levels Update 1
variable fix
Adding Chemistry Set and Goujian to Slips library
Slips lib Update
[thtracker] variable fix
Dev -> Live
Changed to use boolbits and added Master Levels menu display data
Change to use Refs
Re-add Master flags comment
I checked in Selbina and the arrival times are correct. https://cdn.discordapp.com/attachments/484050756169760788/978709336333361222/unknown.png
[gametime] fix //gt route
Trusts: Fix for player party member out-of-zone
Add items for June 2022 Update
Added DIKs for f13-f15.
DIKs for f11 & f12
Yush.lua updated DIKs
Yush: Added a VerboseKeys setting to enable key display in each macro set.
There is no spell called "Lightning Threnody"
0x0E8 is an outgoing packet.
[fields lib] fix wrong 0x0E8 packet direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title, I have both 1 and Alt+1 bound. Holding Alt and then pressing 1 would just activate the action assigned to 1. This change will have the side effect that if you have a key combo pressed, say Ctrl+1, you will no longer be able to hold Alt+Ctrl+1 to activate the combo. Are there any other issues with this change?