Skip to content

Use time() instead of TIME_NOW #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.1
Choose a base branch
from

Conversation

ChristopherWalz
Copy link
Contributor

Sending hundreds of emails in a long running task might take some time (depending on the provider and other work in the task) which could result in some emails having an "old" timestamp. An email might arrive at 12:53 (actual time) but have a timestamp of 12:50, because of the long running task.

@dtdesign
Copy link
Member

dtdesign commented May 8, 2025

I can see the point you’re trying to make but I don’t understand what kind of problem is being solved here. Let’s imagine that the email spends some time in the queue of your mail server for whatever reason. Your timestamp might now be more recent, but when the email is received it is still behind some time.

This is especially true for email servers that are required to be tolerant about reaching the destination server and usually use an exponential back-off to delay the delivery.

PS: $this->date = new \DateTime('now'); would be more reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants