Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Template: Suggest linking the issue #68924

Merged
merged 4 commits into from
Jan 29, 2025
+3 −0
Merged

PR Template: Suggest linking the issue #68924

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d8c212
PR Template: Suggest linking the issue
Mamaduka Jan 28, 2025
c9d912f
Suggestion
Mamaduka Jan 28, 2025
0f32309
More feedback
Mamaduka Jan 29, 2025
f61804a
Feedback
Mamaduka Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,9 @@
https://github.com/WordPress/gutenberg/blob/trunk/CONTRIBUTING.md -->

## What?
<!-- Link this PR to its associated issue with an appropriate keyword: Closes, See, Follow up to, etc. -->
Closes <!-- #ISSUE-NUMBER or URL -->

<!-- In a few words, what is the PR actually doing? -->

## Why?

Unchanged files with check annotations Beta

View file
test/e2e/specs/site-editor/site-editor-url-navigation.spec.js
.click();
await page
.getByRole( 'button', { name: 'For a specific item' } )
.click();

Check failure on line 44 in test/e2e/specs/site-editor/site-editor-url-navigation.spec.js

GitHub Actions / Playwright - 6

[chromium] › site-editor/site-editor-url-navigation.spec.js:23:2 › Site editor url navigation › Redirection after template creation 

  1) [chromium] › site-editor/site-editor-url-navigation.spec.js:23:2 › Site editor url navigation › Redirection after template creation 
    TimeoutError: locator.click: Timeout 10000ms exceeded.
    Call log:
      - waiting for getByRole('button', { name: 'For a specific item' })


      42 | 		await page
      43 | 			.getByRole( 'button', { name: 'For a specific item' } )
    > 44 | 			.click();
         | 			 ^
      45 | 		await page.getByRole( 'option', { name: 'Demo' } ).click();
      46 | 		await expect( page ).toHaveURL(
      47 | 			'/wp-admin/site-editor.php?p=%2Fwp_template%2Femptytheme%2F%2Fsingle-post-demo&canvas=edit'
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/site-editor-url-navigation.spec.js:44:5
await page.getByRole( 'option', { name: 'Demo' } ).click();
await expect( page ).toHaveURL(
'/wp-admin/site-editor.php?p=%2Fwp_template%2Femptytheme%2F%2Fsingle-post-demo&canvas=edit'