Misc fixes for WordPress-Develop 7.0 merges#75985
Misc fixes for WordPress-Develop 7.0 merges#75985peterwilsoncc wants to merge 8 commits intotrunkfrom
Conversation
|
Flaky tests detected in 9ae2dad. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22467984223
|
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Notes on actions docs inline cc @youknowriad
@westonruter are you able to confirm I've got the sourceURL syntax for the inline styles correct.
| /** | ||
| * Fires as the {{PAGE_SLUG}} screen is initialized. | ||
| */ | ||
| do_action( '{{PAGE_SLUG}}-wp-admin_init' ); |
There was a problem hiding this comment.
This might be better as a wp-admin_init-{$page_slug} so it can be documented once as a dynamic hook. Otherwise the docs parser will be full of near identical items. With generated files an approach will need to be figured out to avoid duplicate docs within the code base.
MIght also need a generic version that passes the page slug as a parameter.
|
|
||
| // Fire init action for extensions to register routes and menu items | ||
| /** | ||
| * Fire init action for extensions to register routes and menu items. |
There was a problem hiding this comment.
This is not quite correct but I am having trouble figuring out the difference between page and admin page templates.
peterwilsoncc
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
peterwilsoncc
added
the
[Type] Code Quality
peterwilsoncc
changed the title
1 participant
What?
Miscellaneous fixes for WordPress-Develop merges during the 7.0.0 release cycle.
Anyone should feel free to push to this branch/ping me with things I've missed.
See #75984
Why?
Various code quality fixes.
How?
Code quality
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast