Skip to content

Revert WP version to latest #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Apr 9, 2025

Summary

  • Revert the .wp-env.json changes to latest WP version.
  • Bump Requires at least to 6.8 for auto-sizes plugin

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) skip changelog PRs that should not be mentioned in changelogs labels Apr 9, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (80cc029) to head (2f01c04).
Report is 294 commits behind head on feature/1511-incorporate-layout-constraints-from-ancestors.

Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           feature/1511-incorporate-layout-constraints-from-ancestors    #1980      +/-   ##
==============================================================================================
+ Coverage                                                       69.59%   69.60%   +0.01%     
==============================================================================================
  Files                                                              86       86              
  Lines                                                            7018     7018              
==============================================================================================
+ Hits                                                             4884     4885       +1     
+ Misses                                                           2134     2133       -1     
Flag Coverage Δ
multisite 69.60% <ø> (+0.01%) ⬆️
single 39.68% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review April 9, 2025 11:57
Copy link

github-actions bot commented Apr 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
Copy link
Member

We should wait to merge until the release is made though, right?

@felixarntz
Copy link
Member

We should wait to merge until the release is made though, right?

I think so, yes.

Related: We should probably also update the formally required WordPress version, based on this feature. In https://github.com/WordPress/performance/blob/feature/1511-incorporate-layout-constraints-from-ancestors/plugins/auto-sizes/auto-sizes.php#L6 it still says 6.6. Maybe we can bump it to 6.8 in this PR?

@mukeshpanchal27
Copy link
Member Author

We should wait to merge until the release is made though, right?

Yes, but we can go ahead and merge it since it’s in a feature branch. The final PR for the plugin release (trunk branch) will come after the 6.8 release anyway.

@mukeshpanchal27
Copy link
Member Author

Maybe we can bump it to 6.8 in this PR?

Done in 2f01c04

@mukeshpanchal27
Copy link
Member Author

Why few workflow shows error not other?

Warning: Failed to activate plugin. Current WordPress version (6.7.2) does not meet minimum requirements for Enhanced Responsive Images. The plugin requires WordPress 6.8.

@felixarntz
Copy link
Member

@mukeshpanchal27 Not sure. Let's just wait until the release is out tomorrow and then rerun.

@mukeshpanchal27
Copy link
Member Author

The unit tests passed now. Going to merge now.

@mukeshpanchal27 mukeshpanchal27 merged commit 3c5554a into feature/1511-incorporate-layout-constraints-from-ancestors Apr 16, 2025
20 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the update/revert-wp-version branch April 16, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants