-
Notifications
You must be signed in to change notification settings - Fork 110
Revert WP version to latest #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert WP version to latest #1980
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/1511-incorporate-layout-constraints-from-ancestors #1980 +/- ##
==============================================================================================
+ Coverage 69.59% 69.60% +0.01%
==============================================================================================
Files 86 86
Lines 7018 7018
==============================================================================================
+ Hits 4884 4885 +1
+ Misses 2134 2133 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
We should wait to merge until the release is made though, right? |
I think so, yes. Related: We should probably also update the formally required WordPress version, based on this feature. In https://github.com/WordPress/performance/blob/feature/1511-incorporate-layout-constraints-from-ancestors/plugins/auto-sizes/auto-sizes.php#L6 it still says 6.6. Maybe we can bump it to 6.8 in this PR? |
Yes, but we can go ahead and merge it since it’s in a feature branch. The final PR for the plugin release (trunk branch) will come after the 6.8 release anyway. |
Done in 2f01c04 |
Why few workflow shows error not other?
|
@mukeshpanchal27 Not sure. Let's just wait until the release is out tomorrow and then rerun. |
The unit tests passed now. Going to merge now. |
3c5554a
into
feature/1511-incorporate-layout-constraints-from-ancestors
Summary
.wp-env.json
changes to latest WP version.auto-sizes
plugin