Skip to content

Implement RequirementsUtil and supporting utilities #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Implement RequirementsUtil and supporting utilities #64

wants to merge 4 commits into from
+1,074 −90

Conversation

Ref34t
Copy link
Contributor

@Ref34t Ref34t commented Aug 27, 2025

Summary

Implements Issue #20 MVP requirement for AI utility classes:

  • RequirementsUtil: Complex message analysis and requirements inference (the main utility mentioned in Issue Initial MVP task breakdown #20)
  • CapabilityUtil: Supporting utility for capability and modality management
  • PromptBuilder Integration: Refactored to use RequirementsUtil, eliminating ~60 lines of duplicate code

Key Features

  • Complex Requirements Logic: Analyzes messages to infer required capabilities and options
  • Multi-modal Support: Detects input modalities from message parts (text, image, audio, video, document)
  • Chat History Detection: Automatically adds chat history capability for multi-message conversations
  • Function Calling Support: Detects and adds function declaration requirements

Test Coverage

  • RequirementsUtilTest: 10 tests, 41 assertions
  • CapabilityUtilTest: 14 tests, 95 assertions
  • Total: 24 utility tests, 136 assertions
  • Integration: All existing PromptBuilder tests pass

Files Changed

New Files

  • src/Utils/RequirementsUtil.php - Core requirements inference utility
  • src/Utils/CapabilityUtil.php - Capability management utility
  • tests/unit/Utils/RequirementsUtilTest.php - Comprehensive test suite
  • tests/unit/Utils/CapabilityUtilTest.php - Comprehensive test suite

Modified Files

  • src/Builders/PromptBuilder.php - Integrated with RequirementsUtil

Issue References

Addresses: #20 (MVP requirement: "Implement the AI utility classes, first and foremost RequirementsUtil")

Mohamed Khaled added 4 commits August 27, 2025 17:49
Implement RequirementsUtil and supporting utilities
96ccd83 
- Add RequirementsUtil: Complex message analysis and requirements inference
- Add CapabilityUtil: Capability and modality management utilities
- Refactor PromptBuilder to use RequirementsUtil (eliminates ~60 lines of duplicate code)
- Add comprehensive test suites with 100% coverage
- Ensure full PHPStan compliance and type safety
Fix PHP 7.4 compatibility: Replace nullsafe operators with explicit n…
280f84f 
…ull checks

- Remove ?-> operators (PHP 8.0+) and replace with assertNotNull + regular method calls
- Maintains same test coverage but works with PHP 7.4+ requirement
Fix code style: Break long lines and remove trailing whitespace
ba306ed 
- Break long lines in test assertions to comply with 120 character limit
- Remove trailing whitespace throughout the file
- All PHPCS violations now resolved
Fix PHPStan type annotations
d108d8e
Ref34t pushed a commit to Ref34t/php-ai-client that referenced this pull request Aug 27, 2025
Add utility classes documentation to AiClient
587489c 
Adds documentation references to RequirementsUtil and CapabilityUtil
(from PR WordPress#64) with usage examples showing integration patterns.
@Ref34t Ref34t marked this pull request as ready for review August 27, 2025 15:30
@felixarntz felixarntz mentioned this pull request Aug 29, 2025
Open
@felixarntz
Copy link
Member

@Ref34t Thank you for working on this! Given the updated direction from #66 and your new PR #69, I'm going to close this as obsolete.

@felixarntz felixarntz closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ref34t @felixarntz