Command Palette: Convert commands to sentence case

[priethor]

Closes #190

Converts the Command Palette commands to sentence case, aligning with core commands.

Before	After

[priethor]

As far as I understand, RTL languages don't have upper and lower case, so this shouldn't affect them, nor would they require different treatment; is that correct, @mcsf?

[ockham]

We shouldn't do this 🙈 Operations like this tend to break when applied across different languages, as they make implicit assumptions that don't always apply to all languages.

In this particular change, it breaks for German, where nouns are always capitalized: "book" is "Buch", so "Neues buch hinzufügen" would be very wrong 😬

Basically, localized strings should be left alone (which is also the reason why $labels has so many seemingly redundant strings) -- our best course of action is to continue to use $labels->add_new_item, and to handle the case of the strings in the individual translations.

[priethor]

Thanks Bernie, I suspected this could not play well in other languages 😅

In this case, the add_new_label in English capitalizes both words, as seen in the Add new X button, whereas core commands for adding new pages don't reuse strings and have their own post/page-specific strings.

My best guess here would be to add a completely new label to avoid breaking others, which aligns with the seemingly redundant strings you mentioned. Do you have any other recommendations?

[mcsf]

My best guess here would be to add a completely new label to avoid breaking others, which aligns with the seemingly redundant strings you mentioned. Do you have any other recommendations?

Do you mean a new label which would be the same as add_new_label but with different casing expectations?

[priethor]

I originally meant this, but that's before realizing core add_new_label values have been updated in 6.8 to remove the New part, so what we should do is change the default value for add_new_value to align with core when creating CPTs in SCF (see #193).

[priethor]

Closing this PR as it is the wrong approach: these labels can't and shouldn't be tinkered with at the code level, as they are defined through the post type creation UI, which defaults them to Add New X but are ultimately up to the user to set up. If we want these sentences not to be Title case, we should change the default values, but we shouldn't override what the user configures.