Add nav menu field to scf

[haseebnawaz298]

• this is a very common field that is used a lot, and it is not in scf.

[kraftbj]

This works seems to work well. A couple of questions:

1. Themes without nav menus (e.g. Twenty Twenty Four) will output a notice on the post editor that the theme doesn't support it. I'm curious if there's a better way of handling it (notice on the field group editor? Disable the Nav Menu field when using a theme that doesn't support it? Hide the field on the post editor if the theme doesn't support it, etc.
2. Could you walk me through how you're using this? I'd just like to understand the user journey on it. Something like "this post is about Cats, so I want to display my Animals-specific navigation menu under the top nav" with more flexibility than, say, logic by category?

I mainly want to ensure I'm understanding the need properly.

There are a couple of version updates needed (this will go in 6.5) and tweaking the docs with a typo. [I'm happy to make those edits myself before merge, so no worries there].

With the tutorial, please feel free to be more verbose. The docs, overall, are really spartan but I hope to flesh them out so someone could follow the tutorial from start to finish to add a field, use a field via the post editor, and output the field.

[haseebnawaz298]

1. we can go with showing a message in field group editor and hiding the field from post editor, then we donot need to show any notices.
2. I have worked on many sites where this was needed we did use a plugin for it, but that plugin is no longer maintained.

some of the common use case that i normally use is.

• A second menu that can be set as a global (Theme Options) and also be edited in a page( Page options), if page option is set to be empty global one is fetched.
• it also gives you the ability to show different menus based on different conditions

[haseebnawaz298]

I would also love to help with the docs, just need a direction on how deep we want the docs to be. eg: do we need to give code examples etc, or just basic instructions?

[kraftbj]

1. we can go with showing a message in field group editor and hiding the field from post editor, then we donot need to show any notices.

Awesome; are you good with making those changes on this branch before merging? (note that I did commit the suggestions I made in the initial review so please pull before new commits)

I would also love to help with the docs, just need a direction on how deep we want the docs to be. eg: do we need to give code examples etc, or just basic instructions?

I'd say basic code examples. I'm thinking of two types of users using the docs:

1. The experienced person looking for details. We don't need to do too much beyond good inline documentation of the args, describing the options, etc.
2. Someone new to WordPress/web development who need something more like training wheels.

For the latter person, if they said "I want to add a new field to my site" and stumbled upon SCF, will the tutorial provide them enough information to be able to add the field and output it? Until we have better integration with blocks, that's going to almost always be with small php code.

So, for the nav menu, I would say it could be something like "To output this field, add this code to the theme template, functions.php or elsewhere as needed for implementation ..... get_field(.....)......"

Then with a small tutorial showing "As an example, using a child theme of the Twenty Twelve default theme, if your nav menu field is "special-menu", add [code] to the such and such template.php"

Does that make sense? Obviously few people would need the specific tutorial exactly as written, but enough where someone could get it work in that generic place and be enough to hopefully connect some dots for them.

Additionally, I am okay with merging this (with the notice update) without the docs being 100% and accepting a follow-up PR for it.

Thank you!

[haseebnawaz298]

i will work on this hopefully today or tomorrow, will get back to you soon

[haseebnawaz298]

This is how the notices show in the group field editor now,

field is hidden if there is no support in theme.

[haseebnawaz298]

also updated the docs to be a bit better

[kraftbj]

I haven't actually tested it yet, but a couple of comments from reviewing the code.