Form Post: Fix PHPStan and PHPCS issues. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftbj
reviewed
Mar 14, 2025
kraftbj
reviewed
Mar 14, 2025
tests/php/bootstrap.php
Outdated
| @@ -13,3 +13,6 @@ | |||
|
|
|||
| // Load our plugin. | |||
| require dirname( dirname( __DIR__ ) ) . '/secure-custom-fields.php'; | |||
|
|
|||
| // Load the ACF_Form_Post class. | |||
| require dirname( dirname( __DIR__ ) ) . '/includes/forms/form-post.php'; | |||
There was a problem hiding this comment.
Can you share your thought on adding it to the main bootstrap? My first thought without digging into anything would be to have this require within the test-form-post.php file.
There was a problem hiding this comment.
I required the file on the test one, as you mentioned. Honestly, I'm not 100% sure of the best approach for these unit tests. Let's see in the future for functions that require several files.
kraftbj
added
[Type] Bug
kraftbj
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #67
Refactor
form-post.phpfile to follow PHPCS standards and PHPStan issues. I did manual testing and everything seems to be ok, but I would feel more comfortable if we plan some kind of unit or e2e testing.The riskiest change is removing
$postarrfromwp_insert_post_empty_content. However the variable is not being used inside the function.