Fix wrong license page within the languages es, pt-BR and ja #2483
Conversation
broken link fix for ja language
Fixing the license broken link
broken link fix for the pt-BR language intro page
…he public one Some changelogs this year are linked to Automattic's private repository, which is not accessible to the public who are not in Automattic, so I have replaced them with the public repo link.
josevarghese
changed the title
|
PR links are not valid on this repo! fork and this repo PR number are not in sync! @WordPress/playground-maintainers thoughts on this? Should we drop PR links on changelog items pointing to the fork? |
I think it's okay to have the fork URLs in some entries of the |
…epo to the public one" This reverts commit 44e2161. The reason is that there are no valid public links for those private PRs. We could consider omitting those links (which I believe we did in the private repo at one time), but let's leave as-is for now.
@ajitbohra @zaerl This sounds reasonable to me. It's just the truth that that work was done in a separate, private repo. @josevarghese, after this discussion, I went ahead and reverted the commit to update the CHANGELOG links and will review the rest of this PR after that. |
brandonpayton
changed the title
fellyph
added
the
[Type] Documentation
Motivation for the change, related issues
Right now, the license hyperlink within the intro page for the languages es, pt-BR and ja are added with https://github.com/WordPress/blob/trunk/LICENSE, which is a 404 error page.
Implementation details
Changed the hyperlinks to the correct license page https://github.com/WordPress/wordpress-playground/blob/trunk/LICENSE
Testing Instructions (or ideally a Blueprint)
Visually inspect the updated license links.