-
Notifications
You must be signed in to change notification settings - Fork 386
CORS proxy: Fix custom origin validation during deployment #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brandonpayton
merged 15 commits into
trunk
from
fix-public-cors-proxy-deployment-for-custom-origins
Sep 29, 2025
Merged
CORS proxy: Fix custom origin validation during deployment #2698
brandonpayton
merged 15 commits into
trunk
from
fix-public-cors-proxy-deployment-for-custom-origins
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This works, and I was able to deploy an update so a separate self-hosted Playground web app could use the CORS proxy with a custom origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
We allow customizing the list of origins supported by the CORS proxy, but there is a bug in the deployment script that rejects valid origins within the custom origin list.
Implementation details
This PR:
Testing Instructions (or ideally a Blueprint)