Skip to content

[Website] Remove stray plugin proxy expression#4158

Merged
brandonpayton merged 1 commit into
agent/plugin-proxy-default-response-headersfrom
agent/remove-plugin-response-noop
Jul 23, 2026
Merged

[Website] Remove stray plugin proxy expression#4158
brandonpayton merged 1 commit into
agent/plugin-proxy-default-response-headersfrom
agent/remove-plugin-response-noop

Conversation

@ashfame

@ashfame ashfame commented Jul 23, 2026

Copy link
Copy Markdown
Member

What changed

Remove the standalone $pluginResponse; expression from plugin-proxy.php.

Why

The variable is never assigned or read, and it has no declaration or control-flow effect in PHP. The statement was introduced in 2023 with the Gutenberg pull-request preview flow and has remained unused. Evaluating the undefined variable can emit a warning even though display_errors hides it from the HTTP response.

Impact

There is no intended behavior change. The cleanup removes a no-op expression and avoids a possible undefined-variable warning in server logs.

Stack

This PR is stacked on #4157 and targets its head branch. It should be merged after #4157, which is itself stacked on #4137.

Validation

  • Focused plugin-proxy Playwright suite: 7 passed
  • Website lint: passed
  • PHP syntax check: passed

@ashfame
ashfame marked this pull request as ready for review July 23, 2026 15:37
@brandonpayton
brandonpayton merged commit f6fcf70 into agent/plugin-proxy-default-response-headers Jul 23, 2026
55 checks passed
@brandonpayton
brandonpayton deleted the agent/remove-plugin-response-noop branch July 23, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants