feat: Refactor Banner component to use new styling utilities and tokens #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
refactor-Banner-Styles
|
| Run status |
|
| Run duration | 02m 51s |
| Commit |
|
| Committer | Neha |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
936
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.37%
|
|
|---|---|
|
Untested elements
|
1525
|
|
Tested elements
|
412
|
Accessibility
99.27%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
98
|
josh-bagwell
changed the title
added 3 commits
March 27, 2025 16:05
…and replaced Flex with Element
…Icon width getting overwritten by parent width
josh-bagwell
reviewed
Apr 1, 2025
josh-bagwell
approved these changes
Apr 1, 2025
josh-bagwell
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3142
Refactored the
Bannercomponent to use new system tokens and style utilities.Release Category
Components
Release Note
Refactored the
Bannercomponent to use new system tokens and style utilities.Where Should the Reviewer Start?
/modules/react/banner