-
Notifications
You must be signed in to change notification settings - Fork 846
Adds generic binary heap and d-ary heap #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
|
@dustinhiatt-wf Thoughts? |
|
Thank you for your contribution. I do not work full time on this library but will look at this more carefully in the coming weeks. |
Originally wanted to upgrade to 1.25, but test woulds pass anymore. Upgrading to 1.18 allows us to use generics while preventing any additional maintenance as all tests still passes.
f663a16 to
a55e1fd
Compare
|
Converted to draft: I'm busy improving various aspects of these implementation, strengthening the tests, improving the documentation. But most importantly, making the heaps thread-safe. |
Thank you. I was going to review this library's approach to thread safety (or coroutine safety as it were), so I am glad that you are also considering it. |
a55e1fd to
5214586
Compare
Generic, comparator-based heaps implemented with Go 1.18 generics. See README.md for more details.
5214586 to
cef0b21
Compare
Adds generic binary heap and d-ary heap.
After a quick look into the what's already provided in this project, I didn't find those more basic datastructures. I thought they could be a nice addition to the more advanced ones proposed here.