-
Notifications
You must be signed in to change notification settings - Fork 38
feat: finalize logger #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Is any help needed to finish the logging PRs? We would really like to see the logging feature included in the package, as it would allow us to move completely over to Open Telemetry. |
Hi @tigloo , all the PRs here https://github.com/Workiva/opentelemetry-dart/pulls/yuzurihaaa just with help on fixing the reviews or even help by reviewing the PRs, that would be helpful to get this completed fast 😄 I am trying my best to get this completed too because I am doing some extra package for offline first logs https://github.com/feedmepos/offline-otlp-log-exporter |
is the branch working or is there anything else to do? would be very nice to have this in the package! |
@jodinathan afaik, the branch is working, but it is behind changes after review from the other branches. Do try it out and if u happens to stumble into any issue, let me know. update: I've rebased with the changes from previous branches, but have yet to try it out into any logging services. |
940030c
to
efe0871
Compare
de01f9e
to
fc34a54
Compare
fc34a54
to
a985244
Compare
…ivate `api.Context` with `api.Context?` as constructor argument. If no `api.Context` is passed into constructor, `api.Context.current` is used instead.
a985244
to
531696d
Compare
Which problem is this PR solving?
Fixes # (issue)
close #172
Short description of the change
How Has This Been Tested?
N/A
Checklist: