Skip to content

feat: finalize logger #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 67 commits into
base: master
Choose a base branch
from

Conversation

yuzurihaaa
Copy link
Contributor

Which problem is this PR solving?

  1. Continuation of feat: otlp logger exporter #212
  2. Mark Log as Beta

Fixes # (issue)
close #172

Short description of the change

  1. Change from experimental_api/sdk to api/sdk.
  2. Update README

How Has This Been Tested?

N/A

Checklist:

  • Unit tests have been added
  • Documentation has been updated

@tigloo
Copy link

tigloo commented Jan 30, 2025

Is any help needed to finish the logging PRs? We would really like to see the logging feature included in the package, as it would allow us to move completely over to Open Telemetry.

@yuzurihaaa
Copy link
Contributor Author

Hi @tigloo , all the PRs here https://github.com/Workiva/opentelemetry-dart/pulls/yuzurihaaa just with help on fixing the reviews or even help by reviewing the PRs, that would be helpful to get this completed fast 😄

I am trying my best to get this completed too because I am doing some extra package for offline first logs https://github.com/feedmepos/offline-otlp-log-exporter

@jodinathan
Copy link

is the branch working or is there anything else to do?

would be very nice to have this in the package!

@yuzurihaaa
Copy link
Contributor Author

yuzurihaaa commented Mar 3, 2025

@jodinathan afaik, the branch is working, but it is behind changes after review from the other branches. Do try it out and if u happens to stumble into any issue, let me know.

update: I've rebased with the changes from previous branches, but have yet to try it out into any logging services.

@yuzurihaaa yuzurihaaa force-pushed the feat/finalize-logger branch from 940030c to efe0871 Compare March 3, 2025 02:57
@yuzurihaaa yuzurihaaa force-pushed the feat/finalize-logger branch 2 times, most recently from de01f9e to fc34a54 Compare March 18, 2025 05:05
@yuzurihaaa yuzurihaaa force-pushed the feat/finalize-logger branch from fc34a54 to a985244 Compare March 18, 2025 05:08
@yuzurihaaa yuzurihaaa force-pushed the feat/finalize-logger branch from a985244 to 531696d Compare March 18, 2025 05:16
@evanweible-wf evanweible-wf removed their request for review April 25, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log feature
4 participants