Skip to content

Fix Tracer.startSpan signature #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnnyggalt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Tracer.startSpan signature #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/src/api/trace/tracer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ abstract class Tracer {
/// The [api.Span] is created with the provided name and as a child of any
/// existing span context found in the passed context.
api.Span startSpan(String name,
{api.Context context,
api.SpanKind kind,
List<api.Attribute> attributes,
List<api.SpanLink> links,
Int64 startTime});
{api.Context? context,
api.SpanKind kind = api.SpanKind.internal,
List<api.Attribute> attributes = const [],
List<api.SpanLink> links = const [],
Int64? startTime,
bool newRoot = false});
Copy link
Contributor

@blakeroberts-wk blakeroberts-wk Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change that would require bumping the minor version. If we want this change, we'll want to clean up the other breaking changes that should be contained within the next minor version release

}