-
Notifications
You must be signed in to change notification settings - Fork 2
Native vscode formatting + formatter performance #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
matthewnitschke-wk
wants to merge
19
commits into
master
Choose a base branch
from
use_dart_dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked internals of formatting to better align to vscode's best practices. Also leverages some internal techniques to improve formatting performance
The result of this pr is a full file save format running in
~10ms
. This provides a much improved DX, similar to that of using the default dart format functionality. Example of this running is as follows:Screen.Recording.2025-02-09.at.6.48.05.PM.mov
Due to adhering to the
registerDocumentFormattingEditProvider
we're also able to tap into vscodes default formatting functionality. This means the "Format Document" action/hotkey should work out of the box (with eventual support for "format selection", and "format modified lines")Because of these changes, some configuration settings will need to be updated, and as such, this PR is a major. The changes to
settings.json
are as follows:Details
Relies on: https://github.com/Workiva/over_react_format/pull/152
CI QOL updates in dependabot, and assigning the new owners of @Workiva/fedx
Also closes Stop spamming output tab every time a file saves #23