[pull] master from mangosone:master - #261
Merged
Merged
Conversation
Moves the dep submodule from a065a76 to e3156dc, which adds a fallback download mirror for the Lua tarballs and moves the default LUA_VERSION from lua52 to lua54 (5.4.8). Why it is needed now: lua.org went down on 2026-08-04 and takes every Eluna-enabled build with it. FetchContent pulls the tarball straight from www.lua.org with no fallback, so the failure lands at CMake CONFIGURE time and the whole project stops generating, not merely the Lua target: error: downloading 'https://www.lua.org/ftp/lua-5.2.4.tar.gz' failed connect to 46.175.8.47 port 443 failed: Connection timed out The deps change keeps lua.org as the primary URL and adds ftp2.osuosl.org as a fallback, with URL_HASH verification unchanged on both, so a mirrored tarball is still checked against the same SHA256 as the upstream one. Deliberately stopping at e3156dc rather than taking deps master. The next deps commit (a0e2dd9) replaces the osuosl mirror with assets.getmangos.eu, and that host answers 403 to GitHub Actions runners while serving 200 normally, so it fails in exactly the environment the fallback exists for: error: downloading 'https://assets.getmangos.eu/deps/lua-5.4.8.tar.gz' The requested URL returned error: 403 Verified from a workstation that every user agent gets 200 from that host and that ftp2.osuosl.org serves 5.1.5, 5.2.4 and 5.4.8, so the block is by address, not by client. Tracking deps master rather than the branch mangosfour follows: this core is already past the g3dlite removal, since dep is pinned at a065a76 which is on master. The branch chain would reintroduce g3dlite. The default moves to lua54 (5.4.8) rather than lua55 (5.5.1) because 5.4.8 is the version proven on Windows, Docker and Codestyle CI. Every other version stays selectable via -DLUA_VERSION. Operators running their own Lua scripts should note that bit32, getfenv, setfenv and loadstring were removed in 5.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )