Skip to content

[pull] master from mangosone:master - #261

Merged
pull[bot] merged 1 commit into
World0fWarcraft:masterfrom
mangosone:master
Aug 7, 2026
Merged

[pull] master from mangosone:master#261
pull[bot] merged 1 commit into
World0fWarcraft:masterfrom
mangosone:master

Conversation

@pull

@pull pull Bot commented Aug 7, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

Moves the dep submodule from a065a76 to e3156dc, which adds a fallback
download mirror for the Lua tarballs and moves the default LUA_VERSION
from lua52 to lua54 (5.4.8).

Why it is needed now: lua.org went down on 2026-08-04 and takes every
Eluna-enabled build with it. FetchContent pulls the tarball straight from
www.lua.org with no fallback, so the failure lands at CMake CONFIGURE time
and the whole project stops generating, not merely the Lua target:

    error: downloading 'https://www.lua.org/ftp/lua-5.2.4.tar.gz' failed
    connect to 46.175.8.47 port 443 failed: Connection timed out

The deps change keeps lua.org as the primary URL and adds
ftp2.osuosl.org as a fallback, with URL_HASH verification unchanged on
both, so a mirrored tarball is still checked against the same SHA256 as
the upstream one.

Deliberately stopping at e3156dc rather than taking deps master. The next
deps commit (a0e2dd9) replaces the osuosl mirror with assets.getmangos.eu,
and that host answers 403 to GitHub Actions runners while serving 200
normally, so it fails in exactly the environment the fallback exists for:

    error: downloading 'https://assets.getmangos.eu/deps/lua-5.4.8.tar.gz'
    The requested URL returned error: 403

Verified from a workstation that every user agent gets 200 from that host
and that ftp2.osuosl.org serves 5.1.5, 5.2.4 and 5.4.8, so the block is by
address, not by client.

Tracking deps master rather than the branch mangosfour follows: this core
is already past the g3dlite removal, since dep is pinned at a065a76 which
is on master. The branch chain would reintroduce g3dlite.

The default moves to lua54 (5.4.8) rather than lua55 (5.5.1) because 5.4.8
is the version proven on Windows, Docker and Codestyle CI. Every other
version stays selectable via -DLUA_VERSION. Operators running their own Lua
scripts should note that bit32, getfenv, setfenv and loadstring were
removed in 5.3.
@pull pull Bot locked and limited conversation to collaborators Aug 7, 2026
@pull pull Bot added the ⤵️ pull label Aug 7, 2026
@pull
pull Bot merged commit 5d086dd into World0fWarcraft:master Aug 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant