-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency rubocop-rails to v2.30.1 #7
base: master
Are you sure you want to change the base?
Conversation
|
|
2719370
to
53a140c
Compare
53a140c
to
82e1604
Compare
82e1604
to
263dff0
Compare
263dff0
to
41244c2
Compare
41244c2
to
5a4aefe
Compare
5a4aefe
to
06e3721
Compare
06e3721
to
36ddf2e
Compare
36ddf2e
to
ec630bd
Compare
ec630bd
to
1ec952d
Compare
1ec952d
to
aacd2c2
Compare
aacd2c2
to
67df332
Compare
67df332
to
f873650
Compare
f873650
to
3935f77
Compare
3935f77
to
0f314b5
Compare
0f314b5
to
f8988ca
Compare
f8988ca
to
f8a4247
Compare
f8a4247
to
62ad064
Compare
62ad064
to
fad76bc
Compare
This PR contains the following updates:
2.21.1
->2.30.1
Release Notes
rubocop/rubocop-rails (rubocop-rails)
v2.30.1
Compare Source
Bug fixes
AllCops: TargetRailsVersion
. ([@koic][])AllCops: MigratedSchemaVersion
. ([@koic][])v2.30.0
Compare Source
New features
Bug fixes
Rails/FilePath
cop to correctly handleFile.join
with variables and ignore leading and multiple slashes in string literal arguments forRails.root.join
andFile.join
. ([@ydakuka][])Rails/Delegate
by adding delegation detection forself.class
, constants, class variables, global variables, and instance variables. ([@ydakuka][])v2.29.1
Compare Source
Bug fixes
Rails/StrongParametersExpect
when usingpermit
with no arguments. ([@koic][])Rails/StrongParametersExpect
when using a leading dot multiline call torequire
withpermit
. ([@koic][])Rails/DuplicateAssociation
to handle alias. ([@ydakuka][])TypeError
caused by passing array literals as arguments toFile
methods inRails/FilePath
cop. ([@ydakuka][])TypeError
caused by passing array literals as arguments toFile
methods inRails/RootPathnameMethods
cop. ([@ydakuka][])Rails/SaveBang
to properly handle instance variables. ([@ydakuka][])v2.29.0
Compare Source
New features
Rails/MultipleRoutePaths
cop. ([@koic][])Rails/StrongParametersExpect
cop. ([@koic][])Bug fixes
Rails/ReversibleMigration
when callingdrop_table
without any arguments. ([@earlopain][])Rails/TimeZone
when Time.new has a string argument. ([@mterada1228][])Rails/IndexBy
andRails/IndexWith
whenmap { ... }.to_h
is enclosed in another block. ([@franzliedke][], [@eugeneius][])Rails/IndexBy
andRails/IndexWith
to support numbered block parameters. ([@eugeneius][])Rails/IndexWith
when the value is a hash literal without braces. ([@koic][], [@eugeneius][])Rails/HttpPositionalArguments
cop false positives with arguments forwarding. ([@viralpraxis][])Changes
AllCops: MigratedSchemaVersion
. ([@koic][])v2.28.0
Compare Source
New features
AllCops: MigratedSchemaVersion
config. ([@koic][])Bug fixes
Rails/SelectMap
whenselect
has no receiver and method chains are used. ([@masato-bkn][])Rails/RedundantActiveRecordAllMethod
when usingall
method in block. ([@masato-bkn][])Rails/FilePath
cop error onjoin
method with implicit receiver. ([@viralpraxis][])Rails/FilePath
cop error in case of extra operations inRails.root
interpolation. ([@viralpraxis][])Rails/FilePath
cop error with rescuedRails.root
. ([@viralpraxis][])Changes
Rails/Pluck
to ignoremap/collect
when used inside blocks to prevent potential N+1 queries. ([@masato-bkn][])v2.27.0
Compare Source
Bug fixes
Rails/EnumSyntax
when positional arguments are used and options are not passed as keyword arguments. ([@koic][])Rails/TimeZone
should not report offense onString#to_time
with timezone specifier. ([@armandmgt][])Changes
Rails/TransactionExitStatement
on Rails >= 7.2. ([@earlopain][])Rails/EnvLocal
to handle negated conditions. ([@fatkodima][])Rails/SelectMap
to handle safe navigation operators. ([@fatkodima][])v2.26.2
Compare Source
Bug fixes
Rails/EnumSyntax
when using Ruby 2.7. ([@koic][])Rails/ActionControllerFlashBeforeRender
in combination with implicit returns. ([@earlopain][])Rails/FilePath
when passing an array toFile.join
. ([@earlopain][])Changes
filter
inRails/CompactBlank
. ([@masato-bkn][])v2.26.1
Compare Source
Bug fixes
Rails/EnumSyntax
for non-literal mappings. ([@earlopain][])Rails/WhereEquals
,Rails/WhereNot
, andRails/WhereRange
when qualifying the database name. ([@earlopain][])Changes
Rails/ApplicationRecord
to ignore migrations. ([@fatkodima][])Rails/EnumSyntax
to autocorrect underscored options. ([@fatkodima][])v2.26.0
Compare Source
New features
Rails/EnumSyntax
cop. ([@maxprokopiev][], [@koic][])Rails/EnumHash
cop. ([@ytjmt][])Rails/EnumUniqueness
cop. ([@ytjmt][])Bug fixes
Rails/BulkChangeTable
when the block forchange_table
is empty. ([@earlopain][])Rails/RenderPlainText
when the content type is passed as a constant. ([@earlopain][])Rails/Validation
when passing no arguments. ([@earlopain][])Rails/WhereNot
when using placeholder without second argument. ([@earlopain][])Rails/ActionControllerFlashBeforeRender
when using implicit render or rescue blocks. ([@tldn0718][])Rails/CompactBlank
when usingcollection.reject!
. ([@koic][])Rails/RedundantPresenceValidationOnBelongsTo
when removingpresence
would leave other non-validation options likeallow_blank
without validations. ([@earlopain][])Rails/PluralizationGrammar
aware of byte methods. ([@earlopain][])params
receiver by default forStyle/CollectionMethods
. ([@koic][])Rails/WhereEquals
when the second argument is not yet typed (where("foo = ?", )
). ([@earlopain][])Changes
Rails/CompactBlank
to handleselect(&:present?)
. ([@fatkodima][])Rails/IgnoredSkipActionFilterOption
to handle multiple callbacks. ([@fatkodima][])Rails/WhereEquals
aware ofwhere.not(...)
. ([@earlopain][])Rails/RootPathnameMethods
to detect offenses onDir.[]
. ([@r7kamura][])v2.25.1
Compare Source
Bug fixes
Rails/BulkChangeTable
. ([@ccutrer][])Rails/NotNullColumn
when the block forchange_table
is empty. ([@earlopain][])Rails/WhereRange
autocorrect for complex expressions. ([@fatkodima][])Rails/WhereRange
to correctly handle template strings with extra spaces. ([@fatkodima][])Changes
Rails/Validation
. ([@ChaelCodes][])Rails/LinkToBlank
look intolink_to_if
andlink_to_unless
, too. ([@fwolfst][])Rails/SkipsModelValidations
as unsafe. ([@koic][])Rails/WhereRange
as unsafe autocorrect. ([@fatkodima][])v2.25.0
Compare Source
New features
Rails/WhereRange
cop. ([@fatkodima][])Bug fixes
Rails/Validation
when usingvalidates_size_of
. ([@koic][])Rails/SkipsModelValidations
when usinginsert
orinsert!
with a safe navigator. ([@tldn0718][])Rails/UnknownEnv
when using Rails 7.1. ([@lukasfroehlich1][])Changes
Rails/UnusedIgnoredColumns
by default. ([@earlopain][])change_table
calls for offenses. ([@ccutrer][])Rails/HttpStatus
aware of Rails-specific response assertions. ([@tldn0718][])TargetRailsVersion
the newrequires_gem
API. ([@amomchilov][])v2.24.1
Compare Source
Bug fixes
Rails/ActionControllerFlashBeforeRender
when returningredirect_to
. ([@earlopain][])Rails/UniqBeforePluck
withEnforcedStyle: aggressive
when no receiver. ([@earlopain][])Rails/UnusedIgnoredColumns
when without tables in db/schema.rb. ([@koic][])Rails/WhereMissing
with leadingwhere
without receiver. ([@earlopain][])Rails/ExpandedDateRange
when passing an argument only to the first method call for weeks. ([@earlopain][])Rails/ActiveSupportOnLoad
when calling without arguments. ([@earlopain][])Rails/SaveBang
ifpersisted?
is checked on parenthesised expression. ([@earlopain][])Rails/TimeZone
aware of safe navigation. ([@earlopain][])Changes
active_record_sqlite3adapter
toRails/ActiveSupportOnLoad
. ([@earlopain][])v2.24.0
Compare Source
New features
Bug fixes
Rails/FindBy
when using multi-line leading dot method calls. ([@ymap][])Rails/WhereExists
withEnforcedStyle: where
and implicit receivers. ([@earlopain][])Changes
Rails/EnvironmentVariableAccess
aware of initializers. ([@markokajzer][])object_id
fromRails/DangerousColumnNames
targets. ([@r7kamura][])v2.23.1
Compare Source
Bug fixes
Rails/WhereNot
when calling.where
on an implicit receiver (e.g. inside model code). ([@bquorning][])v2.23.0
Compare Source
New features
Bug fixes
Rails/WhereMissing
where join method is called without arguments. ([@fatkodima][])Rails/Pluck
when using safe navigation method calls. ([@koic][])Rails/ActiveSupportAliases
,Rails/FindBy
,Rails/FindById
,Rails/Inquiry
,Rails/Pick
Rails/PluckId
,Rails/PluckInWhere
,Rails/WhereEquals
,Rails/WhereExists
, andRails/WhereNot
cops aware of safe navigation operator. ([@koic][])Changes
Rails/PluckInWhere
to check for.ids
call. ([@fatkodima][])Nokogiri::HTML.parse
andNokogiri::HTML5.parse
onRails/ResponseParsedBody
. ([@r7kamura][])where.not
forRails/PluckInWhere
. ([@fatkodima][])v2.22.2
Compare Source
Bug fixes
Rails/UnknownEnv
when using Rails 7.1. ([@koic][])Rails/RedundantActiveRecordAllMethod
cop when used with RuboCop 1.51 or lower. ([@koic][])Changes
Rails/RedundantActiveRecordAllMethod
to ignoredelete_all
anddestroy_all
when receiver is an association. ([@masato-bkn][])v2.22.1
Compare Source
Bug fixes
Rails/DuplicateAssociation
when using duplicatebelongs_to
associations of same class without other arguments. ([@koic][])v2.22.0
Compare Source
New features
Rails/EnvLocal
cop. ([@sambostock][])Rails/DuplicateAssociation
aware of duplicateclass_name
. ([@koic][])Rails/RedundantActiveRecordAllMethod
. ([@koic][])Bug fixes
Rails/NotNullColumn
when usingnull: false
for MySQL's TEXT type. ([@koic][])Rails/Output
when output method is called with block argument. ([@koic][])Rails/RedundantActiveRecordAllMethod
when using RuboCop 1.51 or lower. ([@koic][])Rails/RedundantPresenceValidationOnBelongsTo
when usingvalidates
with:if
or:unless
options. ([@koic][])Rails/HasManyOrHasOneDependent
does not add offence when has_many or has_one is called on an explicit receiver. ([@samrjenkins][])Rails/SaveBang
to ignore parenthesis. ([@fatkodima][])Changes
Rails/DangerousColumnNames
. ([@r7kamura][])Rails/ActionFilter
cop; it will be disabled by default. ([@koic][])local
as an environment forRails/UnknownEnv
from Rails 7.1 onward. ([@ghiculescu][])v2.21.2
Compare Source
Bug fixes
Rails/RedundantActiveRecordAllMethod
when using someEnumerable
's methods with block argument. ([@koic][])Rails/SelectMap
when usingselect(:column_name).map(&:column_name)
without receiver model. ([@koic][])Rails/RedundantActiveRecordAllMethod
whenall
has parentheses. ([@masato-bkn][])Rails/UniqueValidationWithoutIndex
with bare validate. ([@jamiemccarthy][])Rails/RedundantActiveRecordAllMethod
when receiver is not an Active Record model. ([@koic][])Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.