(master) wcmConfig: fix fd_refs double-increment in wcmDevOpen() - #18
Open
metux wants to merge 1 commit into
Open
Conversation
For the device that performs the actual open (common->fd_refs == 0), wcmDevOpen() opened the physical fd and set common->fd_refs = 1, but never gave that same priv its own fd via wcmSetFd(). The following 'grab the common descriptor if available' block then saw wcmGetFd(priv) still < 0 for that same priv and ran anyway, calling wcmSetFd() again and incrementing common->fd_refs a second time for what is really only one logical reference. wcmDevClose() decrements fd_refs exactly once per priv whose own fd is >= 0, so the extra increment meant fd_refs never returned to 0 on close, leaking the underlying fd on every plug/unplug cycle. Fix by setting the just-opened priv's own fd right where the open happens, so the fallback block's wcmGetFd(priv) < 0 check correctly sees it as already satisfied and skips the redundant increment. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the device that performs the actual open (common->fd_refs == 0),
wcmDevOpen() opened the physical fd and set common->fd_refs = 1, but
never gave that same priv its own fd via wcmSetFd(). The following
'grab the common descriptor if available' block then saw
wcmGetFd(priv) still < 0 for that same priv and ran anyway, calling
wcmSetFd() again and incrementing common->fd_refs a second time for
what is really only one logical reference.
wcmDevClose() decrements fd_refs exactly once per priv whose own fd is
Fix by setting the just-opened priv's own fd right where the open
happens, so the fallback block's wcmGetFd(priv) < 0 check correctly
sees it as already satisfied and skips the redundant increment.
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net