(master) xf86Wacom: fix unchecked allocations that NULL-deref on OOM - #19
Open
metux wants to merge 1 commit into
Conversation
wcmLog() derefs its calloc() result (via vsnprintf) with no NULL check -- skip logging instead of writing through NULL on allocation failure. wcmTimerNew()/wcmTimerFree()/wcmTimerCancel()/wcmTimerSet() all operate on a WacomTimerPtr without checking it for NULL first. wcmTimerNew() itself derefs its own calloc() result unconditionally, and since callers (wcmConfig.c, up to 3 per new device during PreInit/hotplug) don't check its return value either, a failed allocation there reaches the other three as a NULL WacomTimerPtr. Make all four tolerate NULL, matching the same pattern already used by the underlying xserver TimerCancel()/TimerFree(). Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wcmLog() derefs its calloc() result (via vsnprintf) with no NULL
check -- skip logging instead of writing through NULL on allocation
failure.
wcmTimerNew()/wcmTimerFree()/wcmTimerCancel()/wcmTimerSet() all
operate on a WacomTimerPtr without checking it for NULL first.
wcmTimerNew() itself derefs its own calloc() result unconditionally,
and since callers (wcmConfig.c, up to 3 per new device during
PreInit/hotplug) don't check its return value either, a failed
allocation there reaches the other three as a NULL WacomTimerPtr.
Make all four tolerate NULL, matching the same pattern already used
by the underlying xserver TimerCancel()/TimerFree().
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net