(master) xf86Wacom: release fd reference if wcmDevStart() fails in DEVICE_ON - #20
Open
metux wants to merge 1 commit into
Conversation
The DEVICE_ON case calls wcmDevOpen() (which takes an fd reference, incrementing common->fd_refs) and then wcmDevStart(); on wcmDevStart() failure it jumped straight to 'out' without undoing the wcmDevOpen(), leaking the fd reference (and the underlying fd itself, once/if it was the last reference) every time wcmDevStart() fails on an otherwise successfully-opened device. Call wcmDevClose() on that failure path, mirroring what DEVICE_OFF already does, guarded by the same XI86_SERVER_FD check wcmDevOpen() itself was guarded by. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DEVICE_ON case calls wcmDevOpen() (which takes an fd reference,
incrementing common->fd_refs) and then wcmDevStart(); on
wcmDevStart() failure it jumped straight to 'out' without undoing the
wcmDevOpen(), leaking the fd reference (and the underlying fd itself,
once/if it was the last reference) every time wcmDevStart() fails on
an otherwise successfully-opened device.
Call wcmDevClose() on that failure path, mirroring what DEVICE_OFF
already does, guarded by the same XI86_SERVER_FD check wcmDevOpen()
itself was guarded by.
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net