(release/25.0) hw/xfree86/glamor_egl: do not link staticaly glx library - #3473
Open
metux wants to merge 2 commits into
Conversation
metux
force-pushed
the
pr/release/25.0-hw-xfree86-glamor-egl-do-not-link-staticaly-glx-library_2026-08-03_13-37-54
branch
from
August 3, 2026 11:49
5811594 to
372c6e4
Compare
In a987fc7 commit glx library is statically linked which makes all glx library variables dublicated in glx.so and glamoregl.so files and leads 'split-brain' problem where same symbols exist in different depending on context (this evident when it called using functions with static attribute). This patch exports neccesary glx symbols for glamor library. Signed-off-by: Tautvis <gtautvis@gmail.com> (cherry picked from commit 9b74a3a)
metux
force-pushed
the
pr/release/25.0-hw-xfree86-glamor-egl-do-not-link-staticaly-glx-library_2026-08-03_13-37-54
branch
from
August 3, 2026 11:53
372c6e4 to
3ba75e7
Compare
metux
pushed a commit
that referenced
this pull request
Aug 3, 2026
In a987fc7 commit glx library is statically linked which makes all glx library variables dublicated in glx.so and glamoregl.so files and leads 'split-brain' problem where same symbols exist in different depending on context (this evident when it called using functions with static attribute). This patch exports neccesary glx symbols for glamor library. Signed-off-by: Tautvis <gtautvis@gmail.com> (cherry picked from commit 9b74a3a) PR: #3473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport dashboard
Master: #3213 ✅ merged
Auto-generated backport dashboard — links the source master PR and sibling backports with their merge status.
Backport of #3213 to
release/25.0.Backports both commits of master PR #3213 (merge
6c75731752): themeson
link_withfix (droplibxserver_glx) and its prerequisite commit9b74a3a7f9a2that_X_EXPORTs the GLX symbols glamor needs. Pathsauto-remapped for the
Xext/glx/→glx/reorg (glx/extension_string.h,glxscreens.h,glxserver.h,glxutil.h,include/glx_extinit.h);glx/glxutil.hadditionally gains an explicit#include <X11/Xfuncproto.h>(it no longer pulls in
glxserver.hon this branch).Commit a987fc7 linked glx library
statically, which leaded dublicated glx extension symbols in glx.so and
glamoregl.so libraries. This commit do not link glx directly.
Signed-off-by: Tautvis gtautvis@gmail.com
(cherry picked from commit 6c75731)