-
Notifications
You must be signed in to change notification settings - Fork 6
Update docs index benchmark coverage and fix version selector navigation #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikivanstein
merged 2 commits into
main
from
feature/codex-update-docs/index.rts-and-fix-version-dropdown
Mar 7, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1 @@ | ||
| {%- set _versions = versions | default([]) -%} | ||
| {%- set _current = current_version | default({'name': version}) -%} | ||
|
|
||
| {%- if _versions %} | ||
| <div class="sidebar-tree"> | ||
| <p class="caption" role="heading"> | ||
| <span class="caption-text">Version</span> | ||
| </p> | ||
| <label for="version-selector" class="visually-hidden">Version</label> | ||
| <select | ||
| id="version-selector" | ||
| onchange="if (this.value) window.location.href = this.value;" | ||
| style="width: 100%;" | ||
| > | ||
| {%- for item in _versions %} | ||
| <option value="{{ item.url }}" {% if item.name == _current.name %}selected{% endif %}> | ||
| {{ item.name }} | ||
| </option> | ||
| {%- endfor %} | ||
| </select> | ||
| </div> | ||
| {%- endif %} | ||
| {# Version selector moved to scroll-start.html (top of sidebar). #} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| {%- set _versions = versions | default([]) -%} | ||
| {%- set _current = current_version | default({'name': version}) -%} | ||
| {%- set _docs_base = '/BLADE' -%} | ||
|
|
||
| {%- if _versions %} | ||
| <div class="sidebar-tree"> | ||
| <p class="caption" role="heading"> | ||
| <span class="caption-text">Version</span> | ||
| </p> | ||
| <label for="version-selector" class="visually-hidden">Version</label> | ||
| <select | ||
| id="version-selector" | ||
| style="width: 100%;" | ||
| onchange=" | ||
| if (!this.value) return; | ||
| const target = this.value; | ||
| if (/^https?:\/\//.test(target)) { | ||
| window.location.href = target; | ||
| } else if (target.startsWith('{{ _docs_base }}/')) { | ||
| window.location.href = target; | ||
| } else if (target.startsWith('/')) { | ||
| window.location.href = '{{ _docs_base }}' + target; | ||
| } else { | ||
| window.location.href = '{{ _docs_base }}/' + target; | ||
| } | ||
| " | ||
| > | ||
| {%- for item in _versions %} | ||
| <option | ||
| value="{{ item.url }}" | ||
| {% if item.name == _current.name %}selected{% endif %} | ||
| > | ||
| {{ item.name }} | ||
| </option> | ||
| {%- endfor %} | ||
| </select> | ||
| </div> | ||
| {%- endif %} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new redirect logic rewrites every root-relative version URL to
'/BLADE' + target, which breaks navigation whenever docs are served from a different base path (for example localhttp.serverpreviews or a custom-domain Pages root). In those environments selecting a version now sends users to a non-existent/BLADE/...path instead of the URL produced bysphinx-multiversion, so version switching regresses outside this single deployment layout.Useful? React with 👍 / 👎.