Add a bindable property to open and close the menu from a view model #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For people using mvvm settings, it is handy to have a property to open and close the menu, so I added IsMenuVisible to the container page implementation. You can still use the direct methods or bind the property in XAML or code.
|
If anyone can give me a hand, the CI seems to be failing but I don't see anything related to the change I made.
|
Closed
|
ShowMenuAction targeting null in ViewModel. Can anybody help ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For people using mvvm frameworks, it could be handy to have a property to open and close the menu that they can bind in XAML, so I added IsMenuVisible to the container page implementation.
I hope it is useful to someone. I am using it with Prism.
Please let me know if it helps.