Skip to content

Conversation

SuperstrongBE
Copy link
Contributor

Allow CLI user to export private keys to text or PDF file with embeded QR code allowing import in WebAuth with "Scan to import private".User can export all or selected account by lookup on name
Enregistrementdelecran2025-07-22a10 34 15-ezgif com-video-to-gif-converter

@SuperstrongBE SuperstrongBE marked this pull request as ready for review July 24, 2025 21:26
@SuperstrongBE SuperstrongBE force-pushed the features/export-keys branch from 0b80470 to 0bcbb02 Compare July 25, 2025 07:27
@SuperstrongBE
Copy link
Contributor Author

Rebased on last commit from master

@andreyjamer
Copy link
Collaborator

andreyjamer commented Jul 25, 2025

@SuperstrongBE I'm getting the following error:
image
Looks like fonts should be installed in the system.

UPD. No. Font is in src folder, but not in lib after build. Something is wrong with the build.

@andreyjamer
Copy link
Collaborator

@SuperstrongBE To fix font you need to change prepack command the following way:
"prepack": "rm -rf lib && tsc -b && npx oclif manifest && npx oclif readme && shx cp -r src/templates src/fixtures lib",

And the PDF looks a bit strange:
image
Too many spare space on the first page and the third page in completely unnecessary

@SuperstrongBE
Copy link
Contributor Author

Thank for the review @andreyjamer, will fix it ASAP

@andreyjamer
Copy link
Collaborator

And one more thing: it would be nice to have a possibility to provide a filename. Or the filename should include hour and minutes for example. Now it is easy to override the file. It is very minor, but this is what I spotted

@SuperstrongBE
Copy link
Contributor Author

Good idea i will add this

@SuperstrongBE
Copy link
Contributor Author

@andreyjamer could you finalize/update the review ?

@andreyjamer
Copy link
Collaborator

@SuperstrongBE I'm on vacation for 2 weeks with no access to my laptop. You can ask someone else if it is urgent

@SuperstrongBE
Copy link
Contributor Author

Oh sorry enjoy vacations !!!
🏝️🥳🍾🍸🍹

@SuperstrongBE
Copy link
Contributor Author

@pbatmetal or @DoDoIndex could you review ?

@SuperstrongBE
Copy link
Contributor Author

Fixed one typo reported by @paulgnz !

@SuperstrongBE
Copy link
Contributor Author

Can someone merge the PR ?

@andreyjamer andreyjamer requested a review from DoDoIndex August 18, 2025 06:18
@andreyjamer
Copy link
Collaborator

@SuperstrongBE I asked An to take a look. Then he can merge and release a new version

@SuperstrongBE
Copy link
Contributor Author

@DoDoIndex can you take a look ?

@DoDoIndex
Copy link
Collaborator

Hey @SuperstrongBE. yes, Pravin said he is reviewing. I will confirm with him tomorrow and merge.

@SuperstrongBE
Copy link
Contributor Author

Thank you @DoDoIndex

@pbatmetal
Copy link
Contributor

@SuperstrongBE
I would like to hold on this PR as it deals with private key.
It's a good feature but not really a mandatory requirement from the community.

@SuperstrongBE
Copy link
Contributor Author

@pbatmetal i agree it's not a required from community.
It's more a personal pain : 53 testnet and 14 mainnet account to export and re import on my new phone.
Can keep it on hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants