-
Notifications
You must be signed in to change notification settings - Fork 12
✨ Adding accounts with private export as PDF with QRCode or text #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
✨ Adding accounts with private export as PDF with QRCode or text #29
Conversation
…g password protection as an option for PDF
…e UX message. Print private
0b80470
to
0bcbb02
Compare
Rebased on last commit from master |
@SuperstrongBE I'm getting the following error: UPD. No. Font is in src folder, but not in lib after build. Something is wrong with the build. |
@SuperstrongBE To fix font you need to change And the PDF looks a bit strange: |
Thank for the review @andreyjamer, will fix it ASAP |
And one more thing: it would be nice to have a possibility to provide a filename. Or the filename should include hour and minutes for example. Now it is easy to override the file. It is very minor, but this is what I spotted |
Good idea i will add this |
… Remove orphan pages. Per page warning
@andreyjamer could you finalize/update the review ? |
@SuperstrongBE I'm on vacation for 2 weeks with no access to my laptop. You can ask someone else if it is urgent |
Oh sorry enjoy vacations !!! |
@pbatmetal or @DoDoIndex could you review ? |
Fixed one typo reported by @paulgnz ! |
Can someone merge the PR ? |
@SuperstrongBE I asked An to take a look. Then he can merge and release a new version |
@DoDoIndex can you take a look ? |
Hey @SuperstrongBE. yes, Pravin said he is reviewing. I will confirm with him tomorrow and merge. |
Thank you @DoDoIndex |
@SuperstrongBE |
@pbatmetal i agree it's not a required from community. |
Allow CLI user to export private keys to text or PDF file with embeded QR code allowing import in WebAuth with "Scan to import private".User can export all or selected account by lookup on name
