Skip to content

Merge branch 'develop' into a1q123456/decouple-credential-helpers

1dec6da
Select commit
Loading
Failed to load commit list.
Merged

Decouple CredentialHelpers from xrpld/app/tx #5487

Merge branch 'develop' into a1q123456/decouple-credential-helpers
1dec6da
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 3, 2025 in 1s

79.1% (target 75.0%)

View this Pull Request on Codecov

79.1% (target 75.0%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (c2f3e2e) to head (1dec6da).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5487   +/-   ##
=======================================
  Coverage     79.1%   79.1%           
=======================================
  Files          816     816           
  Lines        71605   71622   +17     
  Branches      8237    8237           
=======================================
+ Hits         56626   56643   +17     
  Misses       14979   14979           
Files with missing lines Coverage Δ
src/xrpld/app/misc/CredentialHelpers.cpp 97.8% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/DeleteAccount.cpp 91.9% <100.0%> (+0.2%) ⬆️
src/xrpld/app/tx/detail/Escrow.cpp 93.6% <100.0%> (+<0.1%) ⬆️
src/xrpld/app/tx/detail/PayChan.cpp 90.5% <100.0%> (+0.1%) ⬆️
src/xrpld/app/tx/detail/Payment.cpp 93.7% <100.0%> (+0.2%) ⬆️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.