-
Notifications
You must be signed in to change notification settings - Fork 1.1k
update mpt docs for permissioneddomains #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rippled-3.0.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, this is set to go into rippled version 3.0.0, not version 2.6.0 which is the next planned release?
| | `temDISABLED` | Either the `PermissionedDomains` or `SingleAssetVault` amendment is disabled. | | ||
| | `temMALFORMED` | The `DomainID` is `0` or empty; you can also receive this error if you include a `DomainID` without setting the `tfMPTRequireAuth` flag. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some other error codes that can occur in the source, such as tecINSUFFICIENT_RESERVE and temBAD_TRANSFER_FEE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how the reader will interpret ... or empty. The DomainID is an optional field, many users might not even want to use it. IF they do use it, it must point to a valid permissioned domain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there are other possible reasons to get temMALFORMED error
| | `tecNO_PERMISSION` | You are trying to lock or unlock an MPT, but the `tfMPTCanLock` flag wasn't set in the `MPTokenIssuanceCreate` transaction. | | ||
| | `temDISABLED` | Either the `PermissionedDomains` or `SingleAssetVault` amendment is disabled. | | ||
| | `temMALFORMED` | You specified a `DomainID` and `Holder` value. You can only set one or the other in a single transaction. You can also receive this error if the transaction isn't changing anything; the transaction must either update a flag or modify the `DomainID`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tecOBJECT_NOT_FOUND and tecNO_DST are examples of a couple other type-specific errors that can occur with this transaction, based on a quick skim of the source.
Yes. Although the changes are in release 2.6.0, they are amendment gated by |
|
|
||
| | Error Code | Description | | ||
| |:--------------------------|:------------| | ||
| | `temDISABLED` | Either the `PermissionedDomains` or `SingleAssetVault` amendment is disabled. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PermissionedDomain does not have to be enabled for MPTokenIssuanceCreate to succeed. It only needs to be enabled if the user tried to use DomainID field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to differentiate the amendments required when including the DomainID field.
Updated
MPTTokenIssuanceCreateandMPTokenIssuanceSettransaction docs to includeDomainIDfield. Also added additional error codes.