handling attributes in JSX elements #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
changed the title
XiNiHa
reviewed
Oct 16, 2024
crates/core/src/shared/transform.rs
Outdated
Comment on lines
3
to
4
| allocator::{Allocator, Vec as OxcVec}, | ||
| ast::ast::{self, JSXElementName}, |
crates/core/src/shared/transform.rs
Outdated
Comment on lines
250
to
262
| let mut child_tmpls = String::new(); | ||
| let info = TransformInfo::default(); | ||
| for child in children { | ||
| match self.transform_node(child, ctx, &info) { | ||
| Some(child_result) => { | ||
| if let Some(child_tmpl) = child_result.template { | ||
| child_tmpls.push_str(&child_tmpl); | ||
| } | ||
| } | ||
| None => {} | ||
| } | ||
| } | ||
| child_tmpls |
There was a problem hiding this comment.
Wouldn't it be more performant to use .filter_map() and .collect::<String>() instead?
There was a problem hiding this comment.
That was also a clean approach. modified here. 0871357
crates/core/src/shared/transform.rs
Outdated
| use super::*; | ||
| use oxc::{allocator::Allocator, parser::Parser, semantic::SemanticBuilder, span::SourceType}; | ||
|
|
||
| struct test_case { |
There was a problem hiding this comment.
Clippy wouldn't like the casing 😅 (I'll set it up in the CI soon)
There was a problem hiding this comment.
clippy would love this fix 3c91e3b
Co-authored-by: Iha Shin (신의하) <[email protected]>
XiNiHa
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handling of
classAttribute in JSX Elements:transform_elementfunction now extracts theclassattribute from JSX elements and includes it in the generated HTML string.Handling Element without
classAttribute:classattribute is not exists, the function generates an HTML string that includes only the element tag and its content. (e.g.,<div>Hello)The expected value of the test used the client-side rendering result of SolidJS.