Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract dom-related code to separate module #5

Merged
merged 1 commit into from
Oct 17, 2024
Merged

extract dom-related code to separate module #5

merged 1 commit into from
Oct 17, 2024

Conversation

XiNiHa
Copy link
Owner

@XiNiHa XiNiHa commented Oct 17, 2024

No description provided.

@XiNiHa XiNiHa changed the title implement basic DOM generation extract dom-related code to separate module Oct 17, 2024
@XiNiHa XiNiHa requested review from notJoon and kiwiyou October 17, 2024 09:36
@XiNiHa XiNiHa marked this pull request as ready for review October 17, 2024 09:36
@XiNiHa XiNiHa merged commit 2df107e into main Oct 17, 2024
16 of 17 checks passed
@XiNiHa XiNiHa deleted the dom-generate branch October 17, 2024 09:38
kiwiyou
kiwiyou approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@kiwiyou kiwiyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@kiwiyou kiwiyou kiwiyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XiNiHa @notJoon @kiwiyou