Skip to content

Commit

Permalink
Remove some wrong header files included in three files. (#8699)
Browse files Browse the repository at this point in the history
* add hipMemsetD32Async().

Signed-off-by: Chiming Zhang <[email protected]>

* fix typo.

Signed-off-by: Chiming Zhang <[email protected]>

* Replace hard coded name with __func__.

Signed-off-by: Chiming Zhang <[email protected]>

* fix staled pointer error.

Signed-off-by: Chiming Zhang <[email protected]>

* fix double allocation issue.

Signed-off-by: Chiming Zhang <[email protected]>

* fix incorrect share_ptr use.

Signed-off-by: Chiming Zhang <[email protected]>

* add hipMemsetD32Async().

Signed-off-by: Chiming Zhang <[email protected]>

* fix typo.

Signed-off-by: Chiming Zhang <[email protected]>

* Replace hard coded name with __func__.

Signed-off-by: Chiming Zhang <[email protected]>

* fix staled pointer error.

Signed-off-by: Chiming Zhang <[email protected]>

* fix double allocation issue.

Signed-off-by: Chiming Zhang <[email protected]>

* 1) add lock in memory_database::get_hip_mem_from_addr()
2) avoid crash from getting hip mem object from null pointer
3) allow setting 0 for kernel arguments

Signed-off-by: Chiming Zhang <[email protected]>

* fix incorrect share_ptr use.

Signed-off-by: Chiming Zhang <[email protected]>

* Fix rebase error.

Signed-off-by: Chiming Zhang <[email protected]>

* move to_hex() into core/common/utils.h

Signed-off-by: Chiming Zhang <[email protected]>

* remove extra member in class copy_buffer.

Signed-off-by: Chiming Zhang <[email protected]>

* fix a typo.

Signed-off-by: Chiming Zhang <[email protected]>

* fix a typo.

Signed-off-by: Chiming Zhang <[email protected]>

* fix some typo and remove template use from copy_buffer class implementation.

Signed-off-by: Chiming Zhang <[email protected]>

* change type of err_msg argument of helper function throw_if() to const char*.

Signed-off-by: Chiming <[email protected]>

* fix incorrect usage of shared_ptr in copy_buffer constructor.

Signed-off-by: Chiming Zhang <[email protected]>

* change the place where host_vec is moved.

Signed-off-by: Chiming Zhang <[email protected]>

* add back missing std::move in copy_from_host_buffer_commad constructor.

Signed-off-by: Chiming Zhang <[email protected]>

* Add initial implementation of hip stream ordered memory allocator.

Signed-off-by: Chiming Zhang <[email protected]>

* Fix the size alignment in memory pool allocator.

Signed-off-by: Chiming Zhang <[email protected]>

* fix rebase error.

Signed-off-by: Chiming Zhang <[email protected]>

* fix rebase error.

Signed-off-by: Chiming Zhang <[email protected]>

* fix rebase error.

Signed-off-by: Chiming Zhang <[email protected]>

* Add comment for the choice of shared_ptr vs unique_ptr in in enqueing the async memcpy commands.

Signed-off-by: Chiming Zhang <[email protected]>

* Add comment for using shared_ptr for storage of pointer to memory_pool pointers.

Signed-off-by: Chiming Zhang <[email protected]>

* use unique_ptr for device_cache.

Signed-off-by: Chiming <[email protected]>

* Fix issues raised in code review.

Signed-off-by: Chiming <[email protected]>

* fix the error in memory::write().

Signed-off-by: Chiming <[email protected]>

* remove curly braces.

Signed-off-by: Chiming <[email protected]>

* Fix issues in hipMallocAsync() and hipFreeAsync().

Signed-off-by: Chiming <[email protected]>

* fix error found in unit testing.

Signed-off-by: Chiming <[email protected]>

* use sub class of hip::memory for async allocation from hip memory pool.

Signed-off-by: Chiming <[email protected]>

* fix the error in sub mem lookup from memory_database.

Signed-off-by: Chiming <[email protected]>

* remove sub_mem address map.

Signed-off-by: Chiming <[email protected]>

* code clean up.

Signed-off-by: Chiming <[email protected]>

* add code for hipDeviceGetDefaultMemPool(), hipDeviceGetMemPool() and hipDeviceSetMemPool().

Signed-off-by: Chiming <[email protected]>

* fix nullptr error.

Signed-off-by: Chiming <[email protected]>

* Fix compile error on Linux.

Signed-off-by: Chiming Zhang <[email protected]>

* Fix compile warning caused by using "int" type.

Signed-off-by: Chiming Zhang <[email protected]>

* fix compile error in release builds.

Signed-off-by: Chiming Zhang <[email protected]>

* Fix compile error.

Signed-off-by: Chiming Zhang <[email protected]>

* remove wrong header files included.

Signed-off-by: Chiming Zhang <[email protected]>

---------

Signed-off-by: Chiming Zhang <[email protected]>
Signed-off-by: Chiming <[email protected]>
Co-authored-by: Chiming <[email protected]>
  • Loading branch information
zhangchiming and Chiming authored Jan 23, 2025
1 parent 01989d3 commit 3836e58
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions src/runtime_src/hip/core/error.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@

#include "core/common/device.h"
#include "core/common/api/bo.h"
#include "xrt/config.h"
#include "xrt/device/hal.h"
#include "xrt/util/range.h"

#include "hip/config.h"
#include "hip/hip_runtime_api.h"
Expand Down
3 changes: 0 additions & 3 deletions src/runtime_src/hip/core/memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
#include "device.h"
#include "experimental/xrt_bo.h"
#include "experimental/xrt_ext.h"
#include "xrt/config.h"
#include "xrt/device/hal.h"
#include "xrt/util/range.h"

namespace xrt::core::hip
{
Expand Down
3 changes: 0 additions & 3 deletions src/runtime_src/hip/core/memory_pool.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
#include "core/common/device.h"
#include "experimental/xrt_bo.h"
#include "experimental/xrt_ext.h"
#include "xrt/config.h"
#include "xrt/device/hal.h"
#include "xrt/util/range.h"

#include "device.h"
#include "memory.h"
Expand Down

0 comments on commit 3836e58

Please sign in to comment.