fix review comments

Signed-off-by: saumya garg <[email protected]>

Author: saumya garg

src/runtime_src/core/common/api/aie/xrt_graph.cpp

@@ -131,7 +131,12 @@ class profiling_impl
 
   ~profiling_impl()
   {
-    device->stop_profiling(profiling_hdl);
+    try {
+      device->stop_profiling(profiling_hdl);
+    }
+    catch(...) {
+      //do nothing
+    }
   }
 
   handle 
@@ -379,7 +384,7 @@ namespace xrt { namespace aie {
 
 profiling::
 profiling(const xrt::device& device)
-  : impl(std::move(create_profiling_event(device)))
+  : detail::pimpl<profiling_impl>(std::move(create_profiling_event(device)))
 {}
 
 int 
@@ -388,7 +393,7 @@ start(xrt::aie::profiling::profiling_option option, const std::string& port1_nam
 {
   int opt = static_cast<int>(option);
   return xdp::native::profiling_wrapper("xrt::aie::profiling::start", [this, opt, &port1_name, &port2_name, value] {
-    return impl->start_profiling(opt, port1_name, port2_name, value);
+    return get_handle()->start_profiling(opt, port1_name, port2_name, value);
   });
 }
 
@@ -397,7 +402,7 @@ profiling::
 read() const
 {
   return xdp::native::profiling_wrapper("xrt::aie::profiling::read", [this] {
-    return impl->read_profiling();
+    return get_handle()->read_profiling();
   });
 }
 
@@ -406,7 +411,7 @@ profiling::
 stop() const
 {
   xdp::native::profiling_wrapper("xrt::aie::profiling::stop", [this] {
-    return impl->stop_profiling();
+    return get_handle()->stop_profiling();
   });
 }
 

src/runtime_src/core/include/xrt/xrt_aie.h

@@ -168,7 +168,32 @@ class profiling_impl;
 class profiling : public detail::pimpl<profiling_impl>
 {
 public:
-  enum class profiling_option : int { io_total_stream_running_to_idle_cycles = 0, io_stream_start_to_bytes_transferred_cycles = 1, io_stream_start_difference_cycles = 2, io_stream_running_event_count = 3 };
+  
+  /**
+   * @enum profiliing_options - contains the enumerated options for performance
+   *				profiling using PLIO and GMIO objects.
+   *
+   * @var io_total_stream_running_to_idle_cycles
+   *   Total clock cycles in between the stream running event and the stream 
+   *   idle event of the stream port in the interface tile.
+   * @var io_stream_start_to_bytes_transferred_cycles
+   *   The clock cycles in between the first stream running event to the event that
+   *   the specified bytes are transferred through the stream port in the interface tile.
+   * @var io_stream_start_difference_cycles
+   *   The clock cycles elapsed between the first stream running events of
+   *   the two platform I/O objects.
+   * @var io_stream_running_event_count
+   *   Number of stream running events 
+   *   
+   * Please refer UG1079 for more details.
+   */
+  enum class profiling_option : int 
+  { 
+    io_total_stream_running_to_idle_cycles = 0, 
+    io_stream_start_to_bytes_transferred_cycles = 1,
+    io_stream_start_difference_cycles = 2,
+    io_stream_running_event_count = 3 
+  };
 
   profiling() = default;
 
@@ -194,6 +219,8 @@ class profiling : public detail::pimpl<profiling_impl>
    * @param value
    *  The number of bytes to trigger the profiling event.
    *
+   * Please refer UG1079 for more details.
+   *
    * This function configures the performance counters in AI Engine by given
    * port names and value. The port names and value will have different
    * meanings on different options.
@@ -215,9 +242,6 @@ class profiling : public detail::pimpl<profiling_impl>
    */
   void
   stop() const;
-
-private:
-  std::shared_ptr<profiling_impl> impl;
 };
 
 }} // aie, xrt