Initial refactoring of AIE trace plugins #7813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 17, 2023 12:47
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
|
Build failed :( |
added 2 commits
November 22, 2023 12:02
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
|
Build failed :( |
1 similar comment
|
Build failed :( |
|
retest this please. (perforce error) |
|
Build failed :( |
|
Retest this please |
|
Build failed :( |
|
Retest this please |
|
Build failed :( |
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
added 2 commits
December 1, 2023 10:06
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
Signed-off-by: Paul Schumacher <[email protected]>
|
|
Build Passed! |
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
jvillarre
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
AIE trace plugin implementation files were large, had lots of common code, and lacked some documentation
How problem was solved, alternative solutions (if any) and why they were rejected
Common functions were separated out, and documentation and messages were added
Risks (if any) associated the changes in the commit
Bugs in common functions will be reflected in all implementations
What has been tested and how, request additional testing if necessary
Tested on vck190 and vek280
Documentation impact (if any)
N/A