Create file with unique name to dump usage metrics #7831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbramand-xilinx
requested review from
chvamshi-xilinx
and removed request for
rozumx
|
Build failed :( |
Signed-off-by: rbramand <[email protected]>
rbramand-xilinx
force-pushed
the
usage_metrics
branch
from
38903be to
2d3c5f8
Compare
|
Build Passed! |
chvamshi-xilinx
approved these changes
Dec 5, 2023
Signed-off-by: rbramand <[email protected]>
|
Build Passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When dumping usage metrics into JSON file, the file name is not unique. Including pid in the file name to create unique file as the log is dumped per process.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
PR - #7788 introduced the bug
This bug was detected when debugging CR - https://jira.xilinx.com/browse/CR-1181804. Files names matched for processes exiting at same time and there was issue of files being overwritten.
How problem was solved, alternative solutions (if any) and why they were rejected
Problem was solved by adding pid in file name as log is dumped per process and it will be unique
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested with the application that is attached with CR and things are working as expected
Documentation impact (if any)
NA