EDGEML-6881 Random test failure when looking for driver store path #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust copying of wchar[] array into std::wstring accounting for bytes vs wchar. Code queries windows adpater for driver store path. The driver store path is returned as array of wchar but was copied as bytes, resulting in copying from unallocated memory. This bug was introduced in Xilinx#7679 and is present in MCDM drops starting M6. Signed-off-by: Soren Soe <[email protected]>
|
Merging without waiting for CI to finish. The change passes all build steps, but is not exercised by any testing. |
|
Build failed :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Adjust copying of wchar[] array into std::wstring accounting for bytes vs wchar.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
This bug was introduced in #7679 and is present in MCDM drops starting M6.
How problem was solved, alternative solutions (if any) and why they were rejected
Code queries windows adpater for driver store path. The driver store path is returned as array of wchar but was copied as bytes, resulting in copying from unallocated memory.