Skeleton directory and build infrastructure for HIP bindings #7857
Conversation
Very preliminary infra for HIP bindings. Build on linux with `build.sh -hip [other options]` Signed-off-by: Soren Soe <[email protected]>
|
Build Passed! |
src/runtime_src/hip/core/device.cpp
Outdated
| // Copyright (C) 2023 Advanced Micro Device, Inc. All rights reserved. | ||
| #include "device.h" | ||
|
|
||
| namespace xrthip_core { |
There was a problem hiding this comment.
Something more C++17 friendly and clearer like xrt::hip::core?
There was a problem hiding this comment.
@keryell . I thought hard and long about this. I don't want xrt:: because that namespace is reserved for anything publicly visible from XRT, e.g. our public APIs. This is an internal namespace, the only thing that will eventually be exported are the APIs declarations, if any of these are C++ they will be in namespace xrt::hip. FYI, in xrt_coreutil we use namespace xrt_core for exactly the same reason. So, believe or not, like it or not, this is actually thought through, :-)
For reference, the internals of core XRT are in namespace xrt_core, so xrthip_core, kind of matches that; that was the thinking at least.
There was a problem hiding this comment.
@stsoe So, believe or not, like it or not, this is actually thought through, :-)
Of course I think this is not some random writing. ;-) Thanks for the context.
Cf Doxygen \namespace to document a namespace. so this is not lost? :-)
There was a problem hiding this comment.
@keryell Maybe I should relax the xrt:: constraint and clean up this nonsensical use of namespaces. Replace xrt_core with xrt::core, replace xrthip_core with xrt::hip::core. Continue to use xrt:: for publicly exported XRT native C++ APIs, use xrt::hip for publicly exported XRT C++ HIP APIs if any. At the same time I could use xrt::opencl::core for the opencl bindings which for historical reasons are in yet another obscure namespace xocl . Is that a more intuitive convention?
There was a problem hiding this comment.
Actually, maybe it should be xrt::core::hip, xrt::core::opencl which would make it much easier for the bindings implementation to reference xrt::core which will be used heavily?
|
Build Passed! |
Very preliminary infra for HIP bindings.
Build on linux with
build.sh -hip [other options]