P1 - Initial changes for removal of xcl apis #7860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbramand <[email protected]>
rbramand-xilinx
requested review from
chvamshi-xilinx,
venkatp-xilinx,
stsoe and
rozumx
as code owners
rbramand-xilinx
requested review from
IshitaGhosh
and removed request for
rozumx and
venkatp-xilinx
|
Build failed :( |
Signed-off-by: rbramand <[email protected]>
|
Build Passed! |
stsoe
requested changes
Dec 20, 2023
There was a problem hiding this comment.
@rajkumar-xilinx , please fix the mixed case structs.
I started adding changes for a few, but it's easier you sweep through and fix them.
| } | ||
| }; | ||
|
|
||
| struct device_clock_freq_MHz { |
There was a problem hiding this comment.
No CamelCase
Suggested change
| struct device_clock_freq_MHz { | |
| struct device_clock_freq_mhz { |
| @@ -940,6 +1033,13 @@ initialize_query_table() | |||
| emplace_func4_request<query::spc_status, spc_status>(); | |||
| emplace_func4_request<query::accel_deadlock_status, accel_deadlock_status>(); | |||
| emplace_func4_request<query::dtbo_path, dtbo_path>(); | |||
|
|
|||
| emplace_func4_request<query::debug_ip_layout_path, debug_ip_layout_path>(); | |||
| emplace_func0_request<query::device_clock_freq_MHz, device_clock_freq_MHz>(); | |||
There was a problem hiding this comment.
Suggested change
| emplace_func0_request<query::device_clock_freq_MHz, device_clock_freq_MHz>(); | |
| emplace_func0_request<query::device_clock_freq_mhz, device_clock_freq_mhz>(); |
IshitaGhosh
approved these changes
Dec 21, 2023
Sure |
Signed-off-by: rbramand <[email protected]>
|
Build Passed! |
chvamshi-xilinx
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This commit adds new queries which will be used in XDP code base. XDP code will be moved from using xcl apis to query calls to fetch information. Confluence page capturing this work - https://confluence.xilinx.com/display/XSW/Vitis-9976+Work
This change is part of series of changes which aim to remove release of xcl apis
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
New queries are added, XDP code will now link to xrt_coreutil which will be platform independent
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested build flows (PCIE - Linux/Windows, Edge)
After XDP code adds these queries they will do functionality test with their test cases
Documentation impact (if any)
NA