Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency installation, build and packaging scripts for AlmaLinux9 #7861

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

qberthet
Copy link
Contributor

Problem solved by the commit

While not a supported OS, XRT can be built and used on AlmaLinux 9, but there is some checks for specific linux flavors which forbid to run dependency installation script and packaging (Build is mostly ok, except for location of pybind11).

How problem was solved, alternative solutions (if any) and why they were rejected

With the proposed modifications, dependency installation script, build and packaging works on AlmaLinux9

What has been tested and how, request additional testing if necessary

Tested on almalinux:latest docker and a fresh almalinux-minimal native install.

Caveat: on docker image, the curl-minimal clash with the installation of curl until --allowerasing is used during yum install. As this change would be more invasive and probably controversial, it have been left out and using yum install curl --allowerasing before running the xrtdeps.sh script is an easy workaround.

Documentation impact (if any)

This is not an attempt to add AlmaLinux 9 to the supported OS lists, thus no documentation modification is required.

@gbuildx
Copy link
Collaborator

gbuildx commented Dec 20, 2023

Can one of the admins verify this patch?

@stsoe
Copy link
Collaborator

stsoe commented Dec 20, 2023

ok to test

@gbuildx
Copy link
Collaborator

gbuildx commented Dec 21, 2023

Build Passed!

@stsoe stsoe merged commit 2a50537 into Xilinx:master Dec 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants