Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VITIS-11094 Remove device ID and device readiness for Ryzen devices #7879

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

dbenusov
Copy link
Contributor

@dbenusov dbenusov commented Jan 9, 2024

Problem solved by the commit

To prepare xbutil for production for Ryzen devices we are cleaning up ReportHost.

The device ID and device readiness options are not applicable to Ryzen and must be removed.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

No bugs/issues, just enhancements.

How problem was solved, alternative solutions (if any) and why they were rejected

Implemented by modifying the Ryzen device list printout in ReportHost.

Risks (if any) associated the changes in the commit

None.

What has been tested and how, request additional testing if necessary

Ubuntu 22.04 with Ryzen device (simulated via a u55c)

dbenusov@xsjdbenusov50:/proj/rdi/staff/dbenusov$ xbutil examine
WARNING: Unexpected xocl version (2.16.0) was found. Expected 2.17.0, to match XRT tools.
System Configuration
  OS Name              : Linux
  Release              : 6.5.0-rc1+
  Version              : #10 SMP PREEMPT_DYNAMIC Wed Aug 16 22:28:12 PDT 2023
  Machine              : x86_64
  CPU Cores            : 16
  Memory               : 63990 MB
  Distribution         : Ubuntu 22.04 LTS
  GLIBC                : 2.35
  Model                : Precision 5820 Tower
  BIOS vendor          : Dell Inc.
  BIOS version         : 2.0.2

XRT
  Version              : 2.17.0
  Branch               : VITIS-11094
  Hash                 : 101f52fce69f04685d25d4711c39fbdc7ec45b01
  Hash Date            : 2024-01-09 14:27:19
  XOCL                 : 2.16.0, 893580509d3f7b0f1fab5a0da6210c709529a740
  XCLMGMT              : 2.16.0, 893580509d3f7b0f1fab5a0da6210c709529a740

Devices present
BDF             :  Name
----------------------------------------------------
[0000:04:00.1]  :  xilinx_u55c_gen3x16_xdma_base_3

Documentation impact (if any)

None

@gbuildx
Copy link
Collaborator

gbuildx commented Jan 9, 2024

Build failed :(

@dayeh-xilinx
Copy link

retest this please.

@gbuildx
Copy link
Collaborator

gbuildx commented Jan 10, 2024

Build failed :(

Signed-off-by: Daniel Benusovich <[email protected]>
@gbuildx
Copy link
Collaborator

gbuildx commented Jan 12, 2024

Build Passed!

@maxzhen
Copy link
Collaborator

maxzhen commented Jan 16, 2024

Merging it per request by @AShivangi

@maxzhen maxzhen merged commit 3ce1895 into Xilinx:master Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants