Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VITIS-11101 Fix missing platform name in SubCmdValidate #7882

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

dbenusov
Copy link
Contributor

Problem solved by the commit

https://jira.xilinx.com/browse/VITIS-11101
Refactor validate test header to account for differences in ryzen and alveo devices.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

Platform name is displayed as N/A which is incorrect. Introduced in #7784.

How problem was solved, alternative solutions (if any) and why they were rejected

Accounted for the differences in Ryzen and Alveo shim when setting up the validation ptree.

Risks (if any) associated the changes in the commit

None.

What has been tested and how, request additional testing if necessary

Ubuntu 22.04 U55c

dbenusov@xsjdbenusov50:/proj/rdi/staff/dbenusov$ xbutil validate -d -r verify -o /tmp/test.json --force
WARNING: Unexpected xocl version (2.16.0) was found. Expected 2.17.0, to match XRT tools.
Validate Device           : [0000:04:00.1]
    Platform              : xilinx_u55c_gen3x16_xdma_base_3
    SC Version            : 7.1.22
    Platform ID           : 97088961-FEAE-DA91-52A2-1D9DFD63CCEF
-------------------------------------------------------------------------------
Verbose: Enabling Verbosity
Test 1 [0000:04:00.1]     : verify
    Description           : Run 'Hello World' kernel test
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed
Successfully wrote the JSON file: /tmp/test.json
dbenusov@xsjdbenusov50:/proj/rdi/staff/dbenusov$ cat /tmp/test.json
{
    "logical_devices": [
        {
            "device_id": "0000:04:00.1",
            "platform": "xilinx_u55c_gen3x16_xdma_base_3",
            "platform_id": "97088961-FEAE-DA91-52A2-1D9DFD63CCEF",
            "sc_version": "7.1.22",
            "tests": [
                {
                    "name": "verify",
                    "description": "Run 'Hello World' kernel test",
                    "xclbin": "verify.xclbin",
                    "explicit": "false",
                    "status": "PASSED"
                }
            ]
        }
    ]
}

Windows Build 26016 Virtual Machine

Z:\XRT-MCDM\build\WDebug\xilinx\xrt>xbutil validate -d -r verify -o test.json --force
------------------------------------------------------------
                        EARLY ACCESS
        This release of xbutil contains early access
         experimental features which may have bugs.
------------------------------------------------------------
Validate Device           : [0000:18:00.1]
    Platform              : RyzenAI-Phoenix
-------------------------------------------------------------------------------
Verbose: Enabling Verbosity
Test 1 [0000:18:00.1]     : verify
    Description           : Run 'Hello World' kernel test
    Xclbin                : C:\Windows\System32\DriverStore\FileRepository\ipukmddrv.inf_amd64_2af5076cb652ca7a\validate_phx.xclbin
    Details               : Kernel name is 'DPU_PDI_0'
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed
Successfully wrote the JSON file: test.json
{
    "logical_devices": [
        {
            "device_id": "0000:18:00.1",
            "platform": "RyzenAI-Phoenix",
            "tests": [
                {
                    "name": "verify",
                    "description": "Run 'Hello World' test on IPU",
                    "xclbin": "validate_phx.xclbin",
                    "explicit": "false",
                    "log": [
                        {
                            "Xclbin": "C:\\Windows\\System32\\DriverStore\\FileRepository\\ipukmddrv.inf_amd64_2af5076cb652ca7a\\validate_phx.xclbin"
                        },
                        {
                            "Details": "Kernel name is 'DPU_PDI_0'"
                        }
                    ],
                    "status": "PASSED"
                }
            ]
        }
    ]
}

Documentation impact (if any)

None

…in ryzen and alveo devices

Signed-off-by: Daniel Benusovich <[email protected]>
@dbenusov dbenusov requested a review from AShivangi January 11, 2024 21:14
@dbenusov dbenusov changed the title VITIS-11103 Fix missing platform name in SubCmdValidate VITIS-11101 Fix missing platform name in SubCmdValidate Jan 11, 2024
@gbuildx
Copy link
Collaborator

gbuildx commented Jan 12, 2024

Build Passed!

@maxzhen maxzhen merged commit 8a67776 into Xilinx:master Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants