Add missing library destination for capture library #8756
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libxrt_capture.so is plug-in runtime loaded library it must be released to library destination on Linux and runtime destination on windows. Noticed stray libxrt_capture.so under CMAKE_INSTALL_PREFIX because of the missing library destinaton for the install target. Signed-off-by: Soren Soe <[email protected]>
stsoe
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
The libxrt_capture.so is plug-in runtime loaded library it must be released to library destination on Linux and runtime destination on windows.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Noticed stray libxrt_capture.so under CMAKE_INSTALL_PREFIX because of the missing library destinaton for the install target.