-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRT smi code cleanup to remove device specific help printing logic #8825
Conversation
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!!
Please double check if the copyrights are up to date
Signed-off-by: Akshay Tondak <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Akshay Tondak <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Akshay Tondak <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
Problem solved by the commit
This PR cleans up the xrt-smi code which depended on the configuration embedded in xbutil.cpp.
With all the xrt-smi re-architecture we did previously, there is no longer a need for xrt-smi subcommands to book keep device/platform specific behavior within XRT. Instead its the responsibility of each shim to provide correct configuration. This clean-up aims at simplifying the xrt-smi help printing and option adding logic. There are following broad changes in this PR :
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/VITIS-14551
Discovered through internal testing
How problem was solved, alternative solutions (if any) and why they were rejected
Solved through xrt-smi re-architecture done in last release. This is mostly subsequent code cleanup.
Risks (if any) associated the changes in the commit
This change has a potential of breaking some of the help printing possibly in non xrt-smi code. Will be testing it further
What has been tested and how, request additional testing if necessary
Tested for all 3 commands on windows.
Documentation impact (if any)
None