CR-1232385 : Fix seg fault when xrt::device is created in a loop in pcie hw_emu flow #8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbramand <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
approved these changes
Mar 24, 2025
chvamshi-xilinx
approved these changes
Mar 24, 2025
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Mar 26, 2025
…ow (#8832) (#8835) Signed-off-by: rbramand <[email protected]> Co-authored-by: rbramand <[email protected]> (cherry picked from commit e2cdce8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Fixed seg fault when xrt::device is created in a loop
The seg fault happens in second run as core device held by shim is recreated and existing one is destroyed and underlying handles are cleaned but in the recreation only cached object ptr is returned which is a dangling ptr.
This issue is only in pcie hw_emu flow.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Creating core device in shim xclOpen call only when it is null (first time)
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested with test case attached in CR (https://github.com/Xilinx/Vitis_Accel_Examples/tree/main/performance/axi_burst_performance) and it passes
Documentation impact (if any)
NA