Build fix on windows after https://github.com/Xilinx/XRT/pull/9651 merge#9669
Merged
chvamshi-xilinx merged 2 commits intoXilinx:masterfrom Mar 14, 2026
Merged
Build fix on windows after https://github.com/Xilinx/XRT/pull/9651 merge#9669chvamshi-xilinx merged 2 commits intoXilinx:masterfrom
chvamshi-xilinx merged 2 commits intoXilinx:masterfrom
Conversation
added 2 commits
March 13, 2026 15:39
Signed-off-by: Akshay Tondak <Akshay.Tondak@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
approved these changes
Mar 13, 2026
Collaborator
stsoe
left a comment
There was a problem hiding this comment.
@chvamshi-xilinx Let's get this fixed properly
Collaborator
Sure @stsoe . @karthdmg-xilinx , Please work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR fixes a build failure we are seeing on windows MCDM build after the merge of #9651 :
The code change suppresses the error/warning and simply calls the deprecated XRT API for the calling python API to handle error logging correctly.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
Existing python users might start seeing this warning but this is expected.
What has been tested and how, request additional testing if necessary
Not tested as this is only suppressing the build warning and the original deprecation is already merged
Documentation impact (if any)
None